tesscut moving target cutouts make individual req per sector #3467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…make individual requests per sector to reduce memory pressure on the service
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3467 +/- ##
==========================================
+ Coverage 71.48% 71.52% +0.03%
==========================================
Files 234 234
Lines 20096 20124 +28
==========================================
+ Hits 14365 14393 +28
Misses 5731 5731 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Could you add another test case to cover the scenario where no TESS sectors are returned? |
snbianco
reviewed
Nov 26, 2025
astroquery/mast/cutouts.py
Outdated
Comment on lines
323
to
335
| if moving_target and sector is None: | ||
| with warnings.catch_warnings(): | ||
| warnings.filterwarnings("ignore", category=NoResultsWarning) | ||
| sector_table = self.get_sectors(objectname=objectname, moving_target=True, mt_type=mt_type) | ||
|
|
||
| localpath_table = Table(names=["Local Path"], dtype=[str]) | ||
|
|
||
| if len(sector_table) == 0: | ||
| warnings.warn("Coordinates are not in any TESS sector.", NoResultsWarning) | ||
| return localpath_table | ||
|
|
||
| # Get unique sectors | ||
| unique_sectors = sorted(set(sector_table["sector"])) |
Contributor
There was a problem hiding this comment.
Can we pull this section of code into a separate helper function that can also be used in get_cutouts?
Contributor
|
Not sure what's up with that test failure, but it doesn't look like it's coming from MAST. |
snbianco
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.