TST: fixing tests that were never collected and run

Author: bsipocz

astroquery/imcce/tests/test_skybot.py

@@ -103,15 +103,16 @@ def test_input():
     assert (a['-refsys'] == 'EQJ2000')
 
 
-def general_query(patch_request):
+def test_general_query(patch_request):
     """test a mock query"""
 
-    a = core.Skybot.cone_search((0, 0), 0.5, 2451200)
+    results = core.Skybot.cone_search((0, 0), 0.5, 2451200)
 
-    assert (len(a) == 141)
-    assert isinstance(a['Number'][0], int)
-    assert (a['RA'][0] == 359.94077541666667*u.deg)
-    assert (a['DEC'][0] == -0.013904166666666667*u.deg)
+    assert len(results) == 4
+    assert results['Number'][0] == 229762
+
+    # mock data serves as a regression for #3301
+    assert results['Name'][0] == "G!kun||'homdima"
 
 
 def test_get_raw_response(patch_request):

astroquery/imcce/tests/test_skybot_remote.py

@@ -4,31 +4,32 @@
 
 import astropy.units as u
 
-from .. import Skybot
+from astroquery.exceptions import NoResultsWarning
+from astroquery.imcce import Skybot
 
 
 @pytest.mark.remote_data
 class TestSBDBClass:
 
-    def general_query(self):
-        a = Skybot.cone_search((0, 0), 0.5, 2451200)
-        assert (len(a) >= 141)
+    def test_general_query(self):
+        a = Skybot.cone_search((0, 0), 0.2, 2451200)
+        assert (len(a) >= 36)
 
-    def failed_query(self):
-        with pytest.raises(RuntimeError):
+    def test_failed_query(self):
+        with pytest.warns(NoResultsWarning, match='No objects were found'):
             Skybot.cone_search((0, 90), 0.00000001, 2451200)
 
-    def planet_moons(self):
+    def test_planet_moons(self):
         a = Skybot.cone_search((221.48552, -14.82952), 0.1,
                                2458291.893831018, location='688')
         assert ('Jupiter' in a['Name'])
-        assert ('Ganymed' in a['Name'])
-        assert (len(a) > 4)
+        assert ('Ganymede' in a['Name'])
+        assert (len(a) > 8)
 
         b = Skybot.cone_search((221.48552, -14.82952), 0.1,
                                2458291.893831018, location='688',
                                find_asteroids=False)
-        assert (len(b) == 4)
+        assert len(b) == 8
 
     def test_uncertainty_filter(self):
         a = Skybot.cone_search((0, 0), 0.3,