Add overloaded shootElement for dynamically finding elements to avoid StaleElementReference

glibas · glibas · commit c6ab2a312090 · 2021-01-04T14:19:13.000Z
diff --git a/src/main/java/com/assertthat/selenium_shutterbug/utils/web/Browser.java b/src/main/java/com/assertthat/selenium_shutterbug/utils/web/Browser.java
@@ -839,8 +839,7 @@ public void scrollToElement(WebElement element) {
     }
 
     public void scrollToElement(By by) {
-        driver.findElement(by);
-        executeJsScript(SCROLL_INTO_VIEW_JS, by);
+        executeJsScript(SCROLL_INTO_VIEW_JS,  driver.findElement(by));
     }
 
     public void scrollToElementVerticalCentered(WebElement element) {

Original file line number	Diff line number	Diff line change
`@@ -839,8 +839,7 @@ public void scrollToElement(WebElement element) {`
`839`	`839`	`}`
`840`	`840`
`841`	`841`	`public void scrollToElement(By by) {`
`842`		`- driver.findElement(by);`
`843`		`- executeJsScript(SCROLL_INTO_VIEW_JS, by);`
	`842`	`+ executeJsScript(SCROLL_INTO_VIEW_JS, driver.findElement(by));`
`844`	`843`	`}`
`845`	`844`
`846`	`845`	`public void scrollToElementVerticalCentered(WebElement element) {`