Skip to content

Commit 54ce131

Browse files
committed
Added Webpack as part of build process to catch issues like in #79
1 parent 11320d0 commit 54ce131

File tree

4 files changed

+26
-3
lines changed

4 files changed

+26
-3
lines changed

.appveyor.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
init:
22
- git config --global core.autocrlf true
3+
install:
4+
- ps: Install-Product node 8 x64
35
branches:
46
only:
57
- master
68
- /^release\/.*$/
79
- /^(.*\/)?ci-.*$/
810
build_script:
9-
- ps: .\run.ps1
11+
- ps: .\build.cmd
1012
clone_depth: 1
1113
os: Visual Studio 2017

.gitignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
11
bower_components/
22
node_modules/
3-
*.nupkg
3+
*.nupkg
4+
npmpackoutput/
5+
test/webpacktest/package*.json
6+
test/webpacktest/dist/

build.msbuild

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,31 @@
44
</ItemGroup>
55
<PropertyGroup>
66
<NuspecPath>Microsoft.jQuery.Unobtrusive.Validation.nuspec</NuspecPath>
7+
<NpmPackOutputDir>$(MSBuildThisFileDirectory)npmpackoutput\</NpmPackOutputDir>
8+
<WebPackTestDir>$(MSBuildThisFileDirectory)test\webpacktest\</WebPackTestDir>
79
</PropertyGroup>
10+
811
<Target Name="Build">
912
<ReadLinesFromFile File="@(VersionFile)">
1013
<Output TaskParameter="Lines" PropertyName="PackageVersion"/>
1114
</ReadLinesFromFile>
1215
<Exec Command="npm install" />
1316
<Exec Command="npm version --no-git-tag-version --allow-same-version $(PackageVersion)" />
14-
<Exec Command="gulp" />
17+
<Exec Command="$(MSBuildThisFileDirectory)node_modules\.bin\gulp" />
1518
<Exec Command="nuget pack $(NuspecPath) -Version $(PackageVersion)" />
19+
20+
<MSBuild Projects ="$(MSBuildProjectFullPath)"
21+
Properties="PackageVersion=$(PackageVersion)"
22+
Targets="Test" />
23+
</Target>
24+
25+
<Target Name="Test">
26+
<Message Text="Testing Webpack build..." />
27+
<MakeDir Directories="$(NpmPackOutputDir)" />
28+
<Exec Command="npm pack $(MSBuildThisFileDirectory)" WorkingDirectory="$(NpmPackOutputDir)" />
29+
<Exec Command="npm init -y" WorkingDirectory="$(WebPackTestDir)" />
30+
<Exec Command="npm install $(NpmPackOutputDir)jquery-validation-unobtrusive-$(PackageVersion).tgz --save-dev --force" WorkingDirectory="$(WebPackTestDir)" />
31+
<Exec Command="npm install webpack webpack-cli --save-dev" WorkingDirectory="$(WebPackTestDir)" />
32+
<Exec Command="npx webpack" WorkingDirectory="$(WebPackTestDir)" />
1633
</Target>
1734
</Project>

test/webpacktest/src/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import _ from "jquery-validation-unobtrusive"

0 commit comments

Comments
 (0)