Update Arcade and run SDL (#54)

Author: BrennanConroy

.azure/default-build.yml

@@ -17,8 +17,8 @@ jobs:
     displayName: ${{ coalesce(parameters.jobName, parameters.agentOs) }}
     dependsOn: ${{ parameters.dependsOn }}
     timeoutInMinutes: ${{ parameters.timeoutInMinutes }}
+    enablePublishBuildAssets: false
     ${{ if and(eq(variables['System.TeamProject'], 'internal'), eq(parameters.agentOs, 'Windows')) }}:
-      enablePublishBuildAssets: true
       enablePublishUsingPipelines: ${{ variables._PublishUsingPipelines }}
     enablePublishTestResults: true # publish test results to AzDO (populates AzDO Tests tab)
     enableTelemetry: true

azure-pipelines.yml

@@ -40,11 +40,6 @@ stages:
       - powershell: "& ./submodules/vcpkg/vcpkg.exe install cpprestsdk:x64-windows --vcpkg-root ./submodules/vcpkg"
         condition: ne(variables.CACHE_RESTORED, 'true')
         displayName: vcpkg install dependencies
-      afterBuild:
-      # Create empty build manifest for Build Asset Registry
-      - powershell: "eng/common/sdk-task.ps1 -restore -task GenerateBuildManifest /p:PackagesToPublishPattern=$(Build.ArtifactStagingDirectory)/*.nupkg /p:AssetManifestFilePath=$(Build.SourcesDirectory)/artifacts/log/$(_BuildConfig)/AssetManifest/manifest.xml /p:ManifestBuildData=\"Location=https://dotnetfeed.blob.core.windows.net/aspnet-aspnetcore/index.json\""
-        displayName: Generate Build Manifest
-        condition: eq(and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')), 'true')
 
   - template: .azure/default-build.yml
     parameters:
@@ -101,41 +96,23 @@ stages:
       - script: brew install gcc
         displayName: Install gcc
 
-  # Publish to the BAR
-  - ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
-    - template: /eng/common/templates/job/publish-build-assets.yml
-      parameters:
-        dependsOn:
-          - Windows_Build_Test_With_CppRestSDK
-          - Mac_Build_Test_With_CppRestSDK
-          - Linux_Build_Test_With_CppRestSDK
-          - Windows_Build_Test
-          - Mac_Build_Test
-          - Linux_Build_Test
-        pool:
-          vmImage: vs2017-win2016
-        publishUsingPipelines: ${{ variables._PublishUsingPipelines }}
-        enablePublishBuildArtifacts: true # publish artifacts/log files
-        continueOnError: true
-
 - ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
-  - template: /eng/common/templates/post-build/post-build.yml
-    parameters:
-      enableSigningValidation: false
-      enableNugetValidation: false
-      publishInstallersAndChecksums: false
-      # This is to enable SDL runs as part of Post-Build Validation Stage
-      SDLValidationParameters:
+  - stage: post_build
+    displayName: Post Build Validation
+    jobs:
+    - template: /eng/common/templates/job/execute-sdl.yml
+      parameters:
         enable: true
+        additionalParameters: ' -SourceToolsList @("policheck","credscan")
+          -TsaInstanceURL $(_TsaInstanceURL)
+          -TsaProjectName $(_TsaProjectName)
+          -TsaNotificationEmail $(_TsaNotificationEmail)
+          -TsaCodebaseAdmin $(_TsaCodebaseAdmin)
+          -TsaBugAreaPath $(_TsaBugAreaPath)
+          -TsaIterationPath $(_TsaIterationPath)
+          -TsaRepositoryName "AspNetCore"
+          -TsaCodebaseName "AspNetCore"
+          -TsaPublish $True
+          -PoliCheckAdditionalRunConfigParams @("UserExclusionPath < $(Build.SourcesDirectory)/eng/PoliCheckExclusions.xml")'
         continueOnError: false
-        params: ' -SourceToolsList @("policheck","credscan")
-        -TsaInstanceURL $(_TsaInstanceURL)
-        -TsaProjectName $(_TsaProjectName)
-        -TsaNotificationEmail $(_TsaNotificationEmail)
-        -TsaCodebaseAdmin $(_TsaCodebaseAdmin)
-        -TsaBugAreaPath $(_TsaBugAreaPath)
-        -TsaIterationPath $(_TsaIterationPath)
-        -TsaRepositoryName "AspNetCore"
-        -TsaCodebaseName "AspNetCore"
-        -TsaPublish $True
-        -PoliCheckAdditionalRunConfigParams @("UserExclusionPath < $(Build.SourcesDirectory)/eng/PoliCheckExclusions.xml")'
+        downloadArtifacts: false