Merge pull request #774 from aspnet/dev/phil-allen-msft/packageUpdates

Set of changes to get librarymanager 'fully passing'

Author: phil-allen-msft

Directory.Packages.props

@@ -9,6 +9,7 @@
   </PropertyGroup>
 
   <ItemGroup>
+    <PackageVersion Include="MessagePack" Version="2.5.187"/>
     <PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" />
     <PackageVersion Include="Microsoft.Build.Framework" Version="17.8.3" />
     <PackageVersion Include="Microsoft.Build.Tasks.Core" Version="17.8.3" />
@@ -44,7 +45,7 @@
     <PackageVersion Include="System.Runtime.Loader" Version="4.3.0" />
     <PackageVersion Include="System.Security.Cryptography.ProtectedData" Version="7.0.0" />
     <PackageVersion Include="System.Security.Permissions" Version="7.0.0" />
-    <PackageVersion Include="System.Text.Json" Version="8.0.4" />
+    <PackageVersion Include="System.Text.Json" Version="8.0.5" />
     <PackageVersion Include="System.Threading.Tasks.Extensions" Version="4.5.4"/>
     <PackageVersion Include="System.ValueTuple" Version="4.5.0" />
 

src/LibraryManager/Json/LibraryStateToFileConverter.cs

@@ -57,7 +57,7 @@ public ILibraryInstallationState ConvertToLibraryInstallationState(LibraryInstal
         [SuppressMessage("Globalization", "CA1307:Specify StringComparison for clarity", Justification = "Not available on net481, not needed here (caseless)")]
         private string ExpandDestination(string destination, string name, string version)
         {
-            if (!destination.Contains("["))
+            if (destination is null || !destination.Contains("["))
             {
                 return destination;
             }

src/LibraryManager/Providers/BaseProvider.cs

@@ -440,6 +440,7 @@ protected virtual string GetCachedFileLocalPath(ILibraryInstallationState state,
         /// Copies ILibraryInstallationState files to cache
         /// </summary>
         /// <param name="state"></param>
+        /// <param name="library"></param>
         /// <param name="cancellationToken"></param>
         /// <returns></returns>
         private async Task<ILibraryOperationResult> RefreshCacheAsync(ILibraryInstallationState state, ILibrary library, CancellationToken cancellationToken)

test/LibraryManager.IntegrationTest/InstallDialogTests.cs

@@ -30,7 +30,7 @@ public void InstallClientSideLibraries_FromProjectRoot_SmokeTest()
             };
 
             string manifestContents = @"{
-  ""version"": ""1.0"",
+  ""version"": ""3.0"",
   ""defaultProvider"": ""cdnjs"",
   ""libraries"": [
     {
@@ -61,7 +61,7 @@ public void InstallClientSideLibraries_FromFolder_SmokeTest()
             };
 
             string manifestContents = @"{
-  ""version"": ""1.0"",
+  ""version"": ""3.0"",
   ""defaultProvider"": ""cdnjs"",
   ""libraries"": [
     {

test/LibraryManager.IntegrationTest/LibmanCompletionTests.cs

@@ -180,12 +180,12 @@ public void LibmanCompletion_LibraryForUnpkg()
             Editor.KeyboardCommands.Enter();
 
             Editor.KeyboardCommands.Type("\"library\":");
-            Editor.KeyboardCommands.Type("bootstr");
-            Helpers.Completion.WaitForCompletionEntries(Editor, new[] { "bootstrap" }, caseInsensitive: true, timeout: 5000);
+            Editor.KeyboardCommands.Type("react");
+            Helpers.Completion.WaitForCompletionEntries(Editor, new[] { "react-redux" }, caseInsensitive: true, timeout: 5000);
 
-            Editor.KeyboardCommands.Backspace(7);
+            Editor.KeyboardCommands.Backspace(5);
             Editor.KeyboardCommands.Type("jque");
-            Helpers.Completion.WaitForCompletionEntries(Editor, new[] { "jquery" }, caseInsensitive: true, timeout: 5000);
+            Helpers.Completion.WaitForCompletionEntries(Editor, new[] { "jquery-csswatch" }, caseInsensitive: true, timeout: 5000);
         }
 
         [TestMethod]