Fix NRE from destination being null

phil-allen-msft · phil-allen-msft · commit 09108e9b9531 · 2024-12-10T16:34:18.000-08:00
diff --git a/src/LibraryManager/Json/LibraryStateToFileConverter.cs b/src/LibraryManager/Json/LibraryStateToFileConverter.cs
@@ -57,7 +57,7 @@ public ILibraryInstallationState ConvertToLibraryInstallationState(LibraryInstal
         [SuppressMessage("Globalization", "CA1307:Specify StringComparison for clarity", Justification = "Not available on net481, not needed here (caseless)")]
         private string ExpandDestination(string destination, string name, string version)
         {
-            if (!destination.Contains("["))
+            if (destination is null || !destination.Contains("["))
             {
                 return destination;
             }

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ public ILibraryInstallationState ConvertToLibraryInstallationState(LibraryInstal`
`57`	`57`	`[SuppressMessage("Globalization", "CA1307:Specify StringComparison for clarity", Justification = "Not available on net481, not needed here (caseless)")]`
`58`	`58`	`private string ExpandDestination(string destination, string name, string version)`
`59`	`59`	`{`
`60`		`- if (!destination.Contains("["))`
	`60`	`+ if (destination is null \|\| !destination.Contains("["))`
`61`	`61`	`{`
`62`	`62`	`return destination;`
`63`	`63`	`}`