feat: Implement clippy support #667

blorente · 2025-12-05T10:33:55Z

Adds clippy support to rules_lint, which is part of #385. It does not support --fix yet, as there are some complications with applying the patches generated by rules_rust.

Caveats:

fix doesn't work.
The machine outputs are in in clippy's native JSON, not SARIF. We could use cargo-sarif to transform it, but we haven't for now.
We treat all clippy warnings as errors. This is because rules_rust will fail the entire execution if there's even one error, so we need to limit the reports to just warnings so that we can continue the target execution and generate useful output files. Because we limit all errors to warnings, we must consider every warning as an error.

Changes are visible to end-users: yes

Searched for relevant documentation and updated as needed: yes
Breaking change (forces users to change their own code or config): Only if they were depending on rules_rust before, it may change their MODULE.lock resolution.
Suggested release notes appear below: yes/no

Test plan

New test cases added
Some of the cases are manual: cd examples && bazel test //test:clippy_ok_binary_with_bad_dep //test:clippy_bad_binary //test:clippy_bad_library

CLAassistant · 2025-12-05T10:34:03Z

All committers have signed the CLA.

aspect-workflows · 2025-12-05T10:35:23Z

Test

All tests were cache hits

5 tests (100.0%) were fully cached saving 2s.

Test

example

8 test targets passed

Targets

//tools/format:format_test_HTML_Jinja_with_djlint [k8-fastbuild]3s
//tools/format:format_test_JavaScript_with_prettier [k8-fastbuild]11s
//tools/format:format_test_Markdown_with_prettier [k8-fastbuild]1s
//tools/format:format_test_Protocol_Buffer_with_buf [k8-fastbuild]515ms
//tools/format:format_test_Python_with_ruff [k8-fastbuild]805ms
//tools/format:format_test_SQL_with_prettier [k8-fastbuild]2s
//tools/format:format_test_Scala_with_scalafmt [k8-fastbuild]6s
//tools/format:format_test_Starlark_with_buildifier [k8-fastbuild]269ms

Total test execution time was 24s. 37 tests (82.2%) were fully cached saving 14s.

Test (WORKSPACE) (Test)

example

⚠️ Buildkite build #543 failed.

@@jq.bzl//:package_metadata failed to build

error loading package '@@jq.bzl//': Unable to find package for
@@package_metadata//rules:package_metadata.bzl: The repository '@@package_metadata' could not be resolved:
Repository '@@package_metadata' is not defined.

💡 To reproduce the build failures, run

bazel build @@jq.bzl//:package_metadata

Just a skeleton for now # Conflicts: # example/.aspect/cli/config.yaml # example/lint.sh # example/tools/lint/linters.bzl

# Conflicts: # example/MODULE.bazel

alexeagle · 2025-12-05T16:24:33Z

lint/clippy.bzl

+
+Typical usage:
+
+First, install `rules_rust` into your repository: https://bazelbuild.github.io/rules_rust/. For instance:


does it require some minimum version of rules_rust to pick up your changes? would be good to document

Good point, it needs 0.67.0. Added a comment.

alexeagle

some initial comments between meetings - awesome!

MODULE.bazel

alexeagle · 2025-12-05T16:29:04Z

lint/clippy.bzl

+    If there is a success marker but the output is not empty, we mark it as a failure.
+    If there is no success marker, the action has failed anyway.
+
+    Please note that all clippy warnings are considered failures.


there's a TODO or "watch issue 385 for updates" here too right? It's not desirable behavior?

Good point, added a comment.

blorente · 2025-12-05T18:30:59Z

I am not sure how, but that buildkite build is failing on this PR, but also failing on my local checkout of main:

➜ git show --stat | head -n 5                     
commit 837bfd82dd11e6c3125ec3a0c87970d8f4fbf30d
Author: Alex Eagle <alex@aspect.dev>
Date:   Fri Dec 5 10:12:48 2025 -0800

    fix: remove dep on aspect_bazel_lib (#668)

➜ (cd example && bqb @jq.bzl//... --noenable_bzlmod)
ERROR: error loading package under directory '': error loading package '@@jq.bzl//': Unable to find package for @@package_metadata//rules:package_metadata.bzl: The repository '@@package_metadata' could not be resolved: Repository '@@package_metadata' is not defined.

@alexeagle do you know why it might have passed on your PR #668?

alexeagle · 2025-12-05T21:39:16Z

lint/clippy.bzl

+    )
+    _marker_to_exit_code(ctx, machine_success_indicator, outputs.machine.out, outputs.machine.exit_code)
+
+    # FIXME: Rustc only gives us JSON output, which we can't turn into SARIF yet.


In theory https://github.com/reviewdog/errorformat/blob/master/fmts/rust.go should guide us to the answer

alexeagle and others added 12 commits December 5, 2025 10:36

WIP: introduce clippy for Rust linting

92c8a00

Just a skeleton for now # Conflicts: # example/.aspect/cli/config.yaml # example/lint.sh # example/tools/lint/linters.bzl

docs: Document state of SARIF in clippy

bf92dca

feat: Add support for user.bazelrc

c0be759

fix: Get clippy from rust toolchain, make lint.sh not crash

c267a1f

CHECK rebase

b046a73

WIP: point to blorente's fork

7f2fdaa

# Conflicts: # example/MODULE.bazel

works without args from rules_rust

9d41c32

clean up

dfa4e18

docs: Add setup documentation

f9a3221

fix: mark --fix as TODO

e00ecee

add tests

d5f095b

fix: Upgrade rules_rust to avoid override

fa2dc16

blorente force-pushed the rust branch from 26eb57a to fa2dc16 Compare December 5, 2025 10:39

blorente added 9 commits December 5, 2025 11:52

self review

7948ab2

fix: Fix rustfmt tests

b3f6fb5

test: Add tests for noclippy tag

07b13f3

fix: Output raw json for machine output

f879a79

fix: Formatting tests

a567818

fix: Add more editions

d459de4

fix: Update rules_rust in example/WORKSPACE.bazel

c77c557

fix: Upgrade toolchains_llvm for rules_cc compat

fd2fd18

fix: Add .clippy.toml to taplo examples

9f1a108

blorente marked this pull request as ready for review December 5, 2025 16:16

fix: Try fixing toolchains_llvm

6f3ca8f

alexeagle reviewed Dec 5, 2025

View reviewed changes

Address comments

fa38ac0

alexeagle reviewed Dec 5, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: Implement clippy support #667

feat: Implement clippy support #667

Uh oh!

blorente commented Dec 5, 2025 •

edited

Loading

Uh oh!

CLAassistant commented Dec 5, 2025 •

edited

Loading

Uh oh!

aspect-workflows bot commented Dec 5, 2025 •

edited

Loading

Uh oh!

alexeagle Dec 5, 2025

Uh oh!

blorente Dec 5, 2025

Uh oh!

alexeagle left a comment

Uh oh!

Uh oh!

alexeagle Dec 5, 2025

Uh oh!

blorente Dec 5, 2025

Uh oh!

blorente commented Dec 5, 2025 •

edited

Loading

Uh oh!

alexeagle Dec 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		Typical usage:

		First, install `rules_rust` into your repository: https://bazelbuild.github.io/rules_rust/. For instance:

Uh oh!

feat: Implement clippy support #667

Are you sure you want to change the base?

feat: Implement clippy support #667

Uh oh!

Conversation

blorente commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes are visible to end-users: yes

Test plan

Uh oh!

CLAassistant commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aspect-workflows bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

example

example

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexeagle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blorente commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

blorente commented Dec 5, 2025 •

edited

Loading

CLAassistant commented Dec 5, 2025 •

edited

Loading

aspect-workflows bot commented Dec 5, 2025 •

edited

Loading

blorente commented Dec 5, 2025 •

edited

Loading