Added test for animator parameters caching

Author: ashblue

Assets/AdncAnimatorHelpers/Editor/Testing/HasParameter.meta

@@ -0,0 +1,105 @@
+using System;
+using Adnc.AnimatorHelpers.Editors.Testing.Utilities;
+using Adnc.AnimatorHelpers.HasParameters;
+using Adnc.Utility.Testing;
+using NUnit.Framework;
+using UnityEngine;
+using Object = UnityEngine.Object;
+
+namespace Adnc.AnimatorHelpers.Editors.Testing.HasParameters {
+    [TestFixture(Category = "HasParameter")]
+    public class TestAnimatorParameters : TestBase {
+        private AnimatorStub _stub;
+
+        [SetUp]
+        public void Setup () {
+            _stub = new AnimatorStub();
+        }
+
+        [TearDown]
+        public void Teardown () {
+            Object.DestroyImmediate(_stub.Animator.gameObject);
+            _stub = null;
+        }
+
+        [Test]
+        public void ErrorsOnNullAnimatorConstructor () {
+            Assert.Throws<ArgumentNullException>(() => { new AnimatorParameters(null); });
+        }
+
+        [Test]
+        public void DoesNotCrashOnNullAnimatorParameters () {
+            _stub.InjectCtrl();
+            var par = new AnimatorParameters(_stub.Animator);
+        }
+
+        [Test]
+        public void StoresAllParameters () {
+            _stub.AnimatorCtrl.AddParameter(new AnimatorControllerParameter {
+                name = "a",
+                defaultBool = true,
+                type = AnimatorControllerParameterType.Bool
+            });
+
+            _stub.InjectCtrl();
+            var par = new AnimatorParameters(_stub.Animator);
+
+            Assert.IsTrue(par.parameters.dic.ContainsKey("a"));
+        }
+
+        [Test]
+        public void StoresAllBools () {
+            _stub.AnimatorCtrl.AddParameter(new AnimatorControllerParameter {
+                name = "a",
+                defaultBool = true,
+                type = AnimatorControllerParameterType.Bool
+            });
+
+            _stub.InjectCtrl();
+            var par = new AnimatorParameters(_stub.Animator);
+
+            Assert.IsTrue(par.bools.dic.ContainsKey("a"));
+        }
+
+        [Test]
+        public void StoresAllFloats () {
+            _stub.AnimatorCtrl.AddParameter(new AnimatorControllerParameter {
+                name = "a",
+                defaultFloat = 1,
+                type = AnimatorControllerParameterType.Float
+            });
+
+            _stub.InjectCtrl();
+            var par = new AnimatorParameters(_stub.Animator);
+
+            Assert.IsTrue(par.floats.dic.ContainsKey("a"));
+        }
+
+        [Test]
+        public void StoresAllInts () {
+            _stub.AnimatorCtrl.AddParameter(new AnimatorControllerParameter {
+                name = "a",
+                defaultInt = 1,
+                type = AnimatorControllerParameterType.Int
+            });
+
+            _stub.InjectCtrl();
+            var par = new AnimatorParameters(_stub.Animator);
+
+            Assert.IsTrue(par.ints.dic.ContainsKey("a"));
+        }
+
+        [Test]
+        public void StoresAllTriggers () {
+            _stub.AnimatorCtrl.AddParameter(new AnimatorControllerParameter {
+                name = "a",
+                type = AnimatorControllerParameterType.Trigger
+            });
+
+            _stub.InjectCtrl();
+            var par = new AnimatorParameters(_stub.Animator);
+
+            Assert.IsTrue(par.triggers.dic.ContainsKey("a"));
+        }
+    }
+}

Assets/AdncAnimatorHelpers/Editor/Testing/HasParameter/TestAnimatorParameters.cs

@@ -0,0 +1,36 @@
+using Adnc.AnimatorHelpers.HasParameters;
+using Adnc.Utility.Testing;
+using NUnit.Framework;
+
+namespace Adnc.AnimatorHelpers.Editors.Testing.HasParameters {
+    [TestFixture(Category = "HasParameter")]
+    public class TestParameters : TestBase {
+        [Test]
+        public void AddIncrementsList () {
+            var p = new Parameters<bool>();
+
+            p.Add("a", true);
+
+            Assert.That(p.list.Count, Is.GreaterThan(0));
+        }
+
+        [Test]
+        public void AddInjectsKeyValueIntoList () {
+            var p = new Parameters<bool>();
+
+            var kv = p.Add("a", true);
+
+            Assert.That(p.list, Contains.Item(kv));
+        }
+
+        [Test]
+        public void AddInjectsKeyValueIntoDictionary () {
+            var p = new Parameters<bool>();
+
+            var kv = p.Add("a", true);
+
+            Assert.That(p.dic, Contains.Key(kv.key));
+            Assert.IsTrue(p.dic.ContainsValue(kv));
+        }
+    }
+}

Assets/AdncAnimatorHelpers/Editor/Testing/HasParameter/TestAnimatorParameters.cs.meta

@@ -24,11 +24,9 @@ public bool IsValid {
         /// Inject the animator stub onto a GameObject
         /// </summary>
         /// <param name="target"></param>
-        public AnimatorStub (GameObject target) {
+        public AnimatorStub (GameObject target = null) {
             if (target == null) {
-                LogError("Please pass in a target to verify. Failed to generate an animator stub");
-
-                return;
+                target = new GameObject("AnimatorStub");
             }
 
             Animator = target.AddComponent<Animator>();

Assets/AdncAnimatorHelpers/Editor/Testing/HasParameter/TestParameters.cs

@@ -10,6 +10,10 @@ public class AnimatorParameters {
         public readonly Parameters<string> triggers = new Parameters<string>();
 
         public AnimatorParameters (Animator animator) {
+            if (animator == null) {
+                throw new ArgumentNullException("animator");
+            }
+
             foreach (var p in animator.parameters) {
                 parameters.Add(p.name, p);
 

Assets/AdncAnimatorHelpers/Editor/Testing/HasParameter/TestParameters.cs.meta

@@ -5,14 +5,16 @@ public class Parameters<V> {
         public readonly List<KeyValue<V>> list = new List<KeyValue<V>>();
         public readonly Dictionary<string, KeyValue<V>> dic = new Dictionary<string, KeyValue<V>>();
 
-        public void Add (string key, V value) {
+        public KeyValue<V> Add (string key, V value) {
             var kv = new KeyValue<V> {
                 key = key,
                 value = value
             };
 
             list.Add(kv);
             dic.Add(key, kv);
+
+            return kv;
         }
     }
 }