Completion of decorator inverter

Author: ashblue

Assets/FluidBehaviorTree/Editor/Testing/Decorators/InverterTest.cs

@@ -1,4 +1,5 @@
 using Adnc.FluidBT.Decorators;
+using Adnc.FluidBT.Tasks;
 using NSubstitute;
 using NUnit.Framework;
 
@@ -35,5 +36,109 @@ public void Returns_false_if_child_is_set_but_set_to_false () {
                 Assert.IsFalse(inverter.Enabled);
             }
         }
+
+        public class UpdateMethod {
+            [Test]
+            public void Returns_failure_when_child_returns_success () {
+                var inverter = new Inverter {
+                    child = A.TaskStub().Build()
+                };
+
+                Assert.AreEqual(TaskStatus.Failure, inverter.Update());
+            }
+
+            [Test]
+            public void Returns_true_when_child_returns_false () {
+                var inverter = new Inverter {
+                    child = A.TaskStub().WithUpdateStatus(TaskStatus.Failure).Build()
+                };
+
+                Assert.AreEqual(TaskStatus.Success, inverter.Update());
+            }
+
+            [Test]
+            public void Returns_continue_when_child_returns_continue () {
+                var inverter = new Inverter {
+                    child = A.TaskStub().WithUpdateStatus(TaskStatus.Continue).Build()
+                };
+
+                Assert.AreEqual(TaskStatus.Continue, inverter.Update());
+            }
+
+            [Test]
+            public void Does_not_crash_if_no_child () {
+                var inverter = new Inverter();
+
+                inverter.Update();
+            }
+
+            [Test]
+            public void Sets_last_status_to_inverted_value () {
+                var inverter = new Inverter {
+                    child = A.TaskStub().Build()
+                };
+
+                var status = inverter.Update();
+
+                Assert.AreEqual(status, inverter.LastStatus);
+            }
+        }
+
+        public class GetAbortConditionMethod {
+            [Test]
+            public void Returns_itself_as_an_abort_condition_if_child_returns () {
+                var task = A.TaskStub()
+                    .WithAbortConditionSelf(true)
+                    .Build();
+
+                var inverter = new Inverter { child = task };
+
+                Assert.AreEqual(inverter, inverter.GetAbortCondition());
+            }
+
+            [Test]
+            public void Does_not_return_an_abort_condition_if_child_does_not_return () {
+                var inverter = new Inverter { child = A.TaskStub().Build() };
+
+                Assert.AreEqual(null, inverter.GetAbortCondition());
+            }
+        }
+
+        public class GetAbortStatusMethod {
+            [Test]
+            public void Returns_status_from_update () {
+                var task = A.TaskStub()
+                    .WithAbortConditionSelf(true)
+                    .Build();
+
+                var inverter = new Inverter { child = task };
+
+                Assert.AreEqual(TaskStatus.Failure, inverter.GetAbortStatus());
+            }
+        }
+
+        public class EndMethod {
+            [Test]
+            public void Calls_end_on_child () {
+                var task = A.TaskStub().Build();
+                var inverter = new Inverter { child = task };
+
+                inverter.End();
+
+                task.Received(1).End();
+            }
+        }
+
+        public class ResetMethod {
+            [Test]
+            public void Runs_reset_on_child () {
+                var task = A.TaskStub().Build();
+                var inverter = new Inverter { child = task };
+
+                inverter.Reset();
+
+                task.Received(1).Reset();
+            }
+        }
     }
 }

Assets/FluidBehaviorTree/Scripts/TaskParents/Decorators/Inverter.cs

@@ -9,27 +9,50 @@ public bool Enabled {
         }
 
         public bool IsLowerPriority { get; } = false;
-        public TaskStatus LastStatus { get; }
+        public TaskStatus LastStatus { get; private set; }
         public ITask child;
 
         public TaskStatus Update () {
-            throw new System.NotImplementedException();
+            if (child == null) {
+                return TaskStatus.Success;
+            }
+
+            var childStatus = child.Update();
+            var status = childStatus;
+
+            switch (childStatus) {
+                case TaskStatus.Success:
+                    status = TaskStatus.Failure;
+                    break;
+                case TaskStatus.Failure:
+                    status = TaskStatus.Success;
+                    break;
+            }
+
+            // @TODO Can be moved to base class
+            LastStatus = status;
+
+            return status;
         }
 
         public ITask GetAbortCondition () {
-            throw new System.NotImplementedException();
+            if (child.GetAbortCondition() != null) {
+                return this;
+            }
+
+            return null;
         }
 
         public void End () {
-            throw new System.NotImplementedException();
+            child.End();
         }
 
         public void Reset (bool hardReset = false) {
-            throw new System.NotImplementedException();
+            child.Reset();
         }
 
         public TaskStatus GetAbortStatus () {
-            throw new System.NotImplementedException();
+            return Update();
         }
     }
 }

Assets/FluidBehaviorTree/Scripts/Tasks/ITask.cs

@@ -27,6 +27,14 @@ public interface ITask {
         /// <returns></returns>
         ITask GetAbortCondition ();
 
+        /// <summary>
+        /// Query this parent task to get the correct corresponding abort type
+        /// Example selector tries all valid conditions until success (or returns failure), while
+        /// sequence returns first item
+        /// </summary>
+        /// <returns></returns>
+        TaskStatus GetAbortStatus ();
+
         /// <summary>
         /// Forcibly end this task. Firing all necessary completion logic
         /// </summary>
@@ -38,13 +46,5 @@ public interface ITask {
         /// </summary>
         /// <param name="hardReset"></param>
         void Reset (bool hardReset = false);
-        
-        /// <summary>
-        /// Query this parent task to get the correct corresponding abort type
-        /// Example selector tries all valid conditions until success (or returns failure), while
-        /// sequence returns first item 
-        /// </summary>
-        /// <returns></returns>
-        TaskStatus GetAbortStatus ();
     }
 }