test: add a test that shows problems with two multiple relationships

Author: barnabasJ

priv/resource_snapshots/test_repo/containers/20251118120836.json

@@ -0,0 +1,31 @@
+{
+  "attributes": [
+    {
+      "allow_nil?": false,
+      "default": "fragment(\"uuid_generate_v7()\")",
+      "generated?": false,
+      "precision": null,
+      "primary_key?": true,
+      "references": null,
+      "scale": null,
+      "size": null,
+      "source": "id",
+      "type": "uuid"
+    }
+  ],
+  "base_filter": null,
+  "check_constraints": [],
+  "custom_indexes": [],
+  "custom_statements": [],
+  "has_create_action": true,
+  "hash": "85454A705DFC565FD634E25E9CE8FB510367A800470B9B85E0FA65494AC296D8",
+  "identities": [],
+  "multitenancy": {
+    "attribute": null,
+    "global": null,
+    "strategy": null
+  },
+  "repo": "Elixir.AshPostgres.TestRepo",
+  "schema": null,
+  "table": "containers"
+}

priv/resource_snapshots/test_repo/containers/20251118120836.json.license

@@ -0,0 +1,3 @@
+SPDX-FileCopyrightText: 2019 ash_postgres contributors <https://github.com/ash-project/ash_postgres/graphs.contributors>
+
+SPDX-License-Identifier: MIT

priv/resource_snapshots/test_repo/items/20251118120836.json

@@ -0,0 +1,122 @@
+{
+  "attributes": [
+    {
+      "allow_nil?": false,
+      "default": "fragment(\"uuid_generate_v7()\")",
+      "generated?": false,
+      "precision": null,
+      "primary_key?": true,
+      "references": null,
+      "scale": null,
+      "size": null,
+      "source": "id",
+      "type": "uuid"
+    },
+    {
+      "allow_nil?": true,
+      "default": "nil",
+      "generated?": false,
+      "precision": null,
+      "primary_key?": false,
+      "references": null,
+      "scale": null,
+      "size": null,
+      "source": "name",
+      "type": "text"
+    },
+    {
+      "allow_nil?": true,
+      "default": "false",
+      "generated?": false,
+      "precision": null,
+      "primary_key?": false,
+      "references": null,
+      "scale": null,
+      "size": null,
+      "source": "active",
+      "type": "boolean"
+    },
+    {
+      "allow_nil?": true,
+      "default": "nil",
+      "generated?": false,
+      "precision": null,
+      "primary_key?": false,
+      "references": {
+        "deferrable": false,
+        "destination_attribute": "id",
+        "destination_attribute_default": null,
+        "destination_attribute_generated": null,
+        "index?": false,
+        "match_type": null,
+        "match_with": null,
+        "multitenancy": {
+          "attribute": null,
+          "global": null,
+          "strategy": null
+        },
+        "name": "items_container_id_fkey",
+        "on_delete": null,
+        "on_update": null,
+        "primary_key?": true,
+        "schema": "public",
+        "table": "containers"
+      },
+      "scale": null,
+      "size": null,
+      "source": "container_id",
+      "type": "uuid"
+    },
+    {
+      "allow_nil?": true,
+      "default": "nil",
+      "generated?": false,
+      "precision": null,
+      "primary_key?": false,
+      "references": null,
+      "scale": null,
+      "size": null,
+      "source": "key",
+      "type": "text"
+    },
+    {
+      "allow_nil?": true,
+      "default": "fragment(\"(now() AT TIME ZONE 'utc')\")",
+      "generated?": false,
+      "precision": null,
+      "primary_key?": false,
+      "references": null,
+      "scale": null,
+      "size": null,
+      "source": "inserted_at",
+      "type": "utc_datetime_usec"
+    },
+    {
+      "allow_nil?": true,
+      "default": "fragment(\"(now() AT TIME ZONE 'utc')\")",
+      "generated?": false,
+      "precision": null,
+      "primary_key?": false,
+      "references": null,
+      "scale": null,
+      "size": null,
+      "source": "updated_at",
+      "type": "utc_datetime_usec"
+    }
+  ],
+  "base_filter": null,
+  "check_constraints": [],
+  "custom_indexes": [],
+  "custom_statements": [],
+  "has_create_action": true,
+  "hash": "8BF7AAEFEDD546F7EF1E399B6267932F80A964026BD5299E54C56AC52346833C",
+  "identities": [],
+  "multitenancy": {
+    "attribute": null,
+    "global": null,
+    "strategy": null
+  },
+  "repo": "Elixir.AshPostgres.TestRepo",
+  "schema": null,
+  "table": "items"
+}

priv/resource_snapshots/test_repo/items/20251118120836.json.license

@@ -0,0 +1,3 @@
+SPDX-FileCopyrightText: 2019 ash_postgres contributors <https://github.com/ash-project/ash_postgres/graphs.contributors>
+
+SPDX-License-Identifier: MIT

priv/test_repo/migrations/20251118120836_migrate_resources67.exs

@@ -0,0 +1,57 @@
+# SPDX-FileCopyrightText: 2019 ash_postgres contributors <https://github.com/ash-project/ash_postgres/graphs.contributors>
+#
+# SPDX-License-Identifier: MIT
+
+defmodule AshPostgres.TestRepo.Migrations.MigrateResources67 do
+  @moduledoc """
+  Updates resources based on their most recent snapshots.
+
+  This file was autogenerated with `mix ash_postgres.generate_migrations`
+  """
+
+  use Ecto.Migration
+
+  def up do
+    alter table(:items) do
+      modify(:updated_at, :utc_datetime_usec, null: true)
+      modify(:inserted_at, :utc_datetime_usec, null: true)
+      add(:name, :text)
+      add(:active, :boolean, default: false)
+      add(:container_id, :uuid)
+    end
+
+    create table(:containers, primary_key: false) do
+      add(:id, :uuid, null: false, default: fragment("uuid_generate_v7()"), primary_key: true)
+    end
+
+    alter table(:items) do
+      modify(
+        :container_id,
+        references(:containers,
+          column: :id,
+          name: "items_container_id_fkey",
+          type: :uuid,
+          prefix: "public"
+        )
+      )
+    end
+  end
+
+  def down do
+    drop(constraint(:items, "items_container_id_fkey"))
+
+    alter table(:items) do
+      modify(:container_id, :uuid)
+    end
+
+    drop(table(:containers))
+
+    alter table(:items) do
+      remove(:container_id)
+      remove(:active)
+      remove(:name)
+      modify(:inserted_at, :utc_datetime_usec, null: false)
+      modify(:updated_at, :utc_datetime_usec, null: false)
+    end
+  end
+end

test/calculation_with_multiple_relationships_test.exs

@@ -0,0 +1,124 @@
+# SPDX-FileCopyrightText: 2019 ash_postgres contributors <https://github.com/ash-project/ash_postgres/graphs.contributors>
+#
+# SPDX-License-Identifier: MIT
+
+defmodule AshPostgres.CalculationWithMultipleRelationshipsTest do
+  @moduledoc """
+  Tests for calculations using multiple relationships to the same resource
+  with different read actions on the Postgres data layer.
+
+  Bug verification: When two relationships are defined to the same resource with different
+  read actions, calculations using each relationship should respect the correct read_action.
+
+  This tests the same behavior as Ash.Test.CalculationWithMultipleRelationshipsTest
+  but with the Postgres data layer to ensure SQL generation is correct.
+  """
+  use AshPostgres.RepoCase, async: false
+
+  alias AshPostgres.Test.{Container, Item}
+
+  test "calculations use correct read actions from their respective relationships" do
+    container = Ash.Seed.seed!(Container, %{})
+
+    item =
+      Ash.Seed.seed!(Item, %{
+        container_id: container.id,
+        name: "Inactive Item",
+        active: false
+      })
+
+    loaded_container = Ash.load!(container, [:item_all])
+    assert item.id == loaded_container.item_all.id
+
+    loaded_container = Ash.load!(container, [:item_active])
+    assert nil == loaded_container.item_active
+
+    loaded_container = Ash.load!(container, [:active_item_name, :all_item_name])
+
+    assert loaded_container.active_item_name == nil
+
+    assert loaded_container.all_item_name == "Inactive Item"
+  end
+
+  test "loading calculations one at a time works" do
+    container = Ash.Seed.seed!(Container, %{})
+
+    item =
+      Ash.Seed.seed!(Item, %{
+        container_id: container.id,
+        name: "Inactive Item",
+        active: false
+      })
+
+    loaded_container = Ash.load!(container, [:item_all])
+    assert item.id == loaded_container.item_all.id
+
+    loaded_container = Ash.load!(container, [:item_active])
+    assert nil == loaded_container.item_active
+
+    loaded_container = Ash.load!(container, [:active_item_name])
+    assert loaded_container.active_item_name == nil
+
+    loaded_container = Ash.load!(container, [:all_item_name])
+    assert loaded_container.all_item_name == "Inactive Item"
+  end
+
+  test "with active item, both calculations return values" do
+    container = Ash.Seed.seed!(Container, %{})
+
+    item =
+      Ash.Seed.seed!(Item, %{
+        container_id: container.id,
+        name: "Active Item",
+        active: true
+      })
+
+    loaded_container = Ash.load!(container, [:item_all])
+    assert item.id == loaded_container.item_all.id
+
+    loaded_container = Ash.load!(container, [:item_active])
+    assert item.id == loaded_container.item_active.id
+
+    loaded_container = Ash.load!(container, [:active_item_name, :all_item_name])
+
+    assert loaded_container.active_item_name == "Active Item"
+    assert loaded_container.all_item_name == "Active Item"
+  end
+
+  test "multiple containers with mixed active/inactive items" do
+    container1 = Ash.Seed.seed!(Container, %{})
+
+    Ash.Seed.seed!(Item, %{
+      container_id: container1.id,
+      name: "Inactive Item 1",
+      active: false
+    })
+
+    container2 = Ash.Seed.seed!(Container, %{})
+
+    Ash.Seed.seed!(Item, %{
+      container_id: container2.id,
+      name: "Active Item 2",
+      active: true
+    })
+
+    _container3 = Ash.Seed.seed!(Container, %{})
+
+    containers =
+      Container
+      |> Ash.Query.sort(:id)
+      |> Ash.Query.load([:active_item_name, :all_item_name])
+      |> Ash.read!()
+
+    [loaded1, loaded2, loaded3] = containers
+
+    assert loaded1.active_item_name == nil
+    assert loaded1.all_item_name == "Inactive Item 1"
+
+    assert loaded2.active_item_name == "Active Item 2"
+    assert loaded2.all_item_name == "Active Item 2"
+
+    assert loaded3.active_item_name == nil
+    assert loaded3.all_item_name == nil
+  end
+end

test/support/domain.ex

@@ -64,6 +64,8 @@ defmodule AshPostgres.Test.Domain do
     resource(AshPostgres.Test.FoodItem)
     resource(AshPostgres.Test.Meal)
     resource(AshPostgres.Test.MealItem)
+    resource(AshPostgres.Test.Container)
+    resource(AshPostgres.Test.Item)
   end
 
   authorization do