Fix staging plugin

ascopes · ascopes · commit af368073bc05 · 2023-01-11T09:36:30.000Z
- Include acceptance tests in release to keep Nexus happy
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -8,11 +8,6 @@ on:
         default: true
         type: boolean
 
-      skip-dependency-scan:
-        description: "Skip dependency scan"
-        default: false
-        type: boolean
-
       skip-deploy:
         description: "Skip deployment step"
         default: false
@@ -23,8 +18,8 @@ on:
         default: false
         type: boolean
 
-      skip-tests:
-        description: "Skip tests"
+      skip-initial-verification:
+        description: "Skip tests, dependency check, formatting, licenses"
         default: false
         type: boolean
 
@@ -61,6 +56,21 @@ jobs:
           gpg-passphrase: GPG_PASSPHRASE
           gpg-private-key: ${{ secrets.GPG_PRIVATE_KEY }}
 
+      - name: Ensure all tests pass
+        if: ${{ ! inputs.skip-initial-verification }}
+        shell: bash
+        run: >-
+          ./mvnw 
+          -B 
+          -e
+          -T4
+          -U
+          -P dependency-check
+          --no-transfer-progress
+          -Dstyle.color=always
+          -Dmaven.wagon.httpconnectionManager.ttlSeconds=120
+          clean verify
+
       - name: Configure Git
         shell: bash
         run: |-
@@ -89,14 +99,13 @@ jobs:
           info "Preparing and performing the release"
           ensure-set OSSRH_USERNAME OSSRH_TOKEN GPG_PASSPHRASE
           
-          build_args=()
-          if [[ '${{ inputs.skip-dependency-check }}' == 'false' ]]; then
-            build_args+=("-P" "dependency-check")
-          fi
-          if [[ '${{ inputs.skip-tests }}' == 'true' ]]; then
-            build_args+=("-Dmaven.test.skip" "-DskipTests")
-          fi
-          
+          build_args=(
+            "-Dmaven.test.skip" 
+            "-DskipTests"
+            "-Dlicense.skip=true"
+            "-Dcheckstyle.skip=true"
+          )
+
           build_goals=()
           if [[ '${{ inputs.skip-deploy }}' == 'true' ]]; then
             build_goals+=("clean" "package" "javadoc:jar")
@@ -120,6 +129,7 @@ jobs:
           SCRIPT
           
           success "Release has been performed successfully"
+
         env:
           OSSRH_USERNAME: ${{ secrets.OSSRH_USERNAME }}
           OSSRH_TOKEN: ${{ secrets.OSSRH_TOKEN }}
diff --git a/acceptance-tests/acceptance-tests-avaje-inject/pom.xml b/acceptance-tests/acceptance-tests-avaje-inject/pom.xml
@@ -28,6 +28,7 @@
 
   <artifactId>acceptance-tests-avaje-inject</artifactId>
   <name>JCT acceptance tests for Avaje Inject</name>
+  <description>Acceptance test components.</description>
 
   <properties>
     <avaje-inject.version>8.11</avaje-inject.version>
diff --git a/acceptance-tests/acceptance-tests-avaje-jsonb/pom.xml b/acceptance-tests/acceptance-tests-avaje-jsonb/pom.xml
@@ -28,6 +28,7 @@
 
   <artifactId>acceptance-tests-avaje-jsonb</artifactId>
   <name>JCT acceptance tests for Avaje JSONB</name>
+  <description>Acceptance test components.</description>
 
   <properties>
     <avaje-jsonb.version>1.1</avaje-jsonb.version>
diff --git a/acceptance-tests/acceptance-tests-checkerframework/pom.xml b/acceptance-tests/acceptance-tests-checkerframework/pom.xml
@@ -28,6 +28,7 @@
 
   <artifactId>acceptance-tests-checkerframework</artifactId>
   <name>JCT acceptance tests for CheckerFramework</name>
+  <description>Acceptance test components.</description>
 
   <properties>
     <argLine>
diff --git a/acceptance-tests/acceptance-tests-dagger/pom.xml b/acceptance-tests/acceptance-tests-dagger/pom.xml
@@ -28,6 +28,7 @@
 
   <artifactId>acceptance-tests-dagger</artifactId>
   <name>JCT acceptance tests for Google Dagger</name>
+  <description>Acceptance test components.</description>
 
   <properties>
     <dagger.version>2.44.2</dagger.version>
diff --git a/acceptance-tests/acceptance-tests-error-prone/pom.xml b/acceptance-tests/acceptance-tests-error-prone/pom.xml
@@ -28,6 +28,7 @@
 
   <artifactId>acceptance-tests-error-prone</artifactId>
   <name>JCT acceptance tests for Google ErrorProne</name>
+  <description>Acceptance test components.</description>
 
   <properties>
     <argLine>
diff --git a/acceptance-tests/acceptance-tests-google-auto-factory/pom.xml b/acceptance-tests/acceptance-tests-google-auto-factory/pom.xml
@@ -28,6 +28,7 @@
 
   <artifactId>acceptance-tests-google-auto-factory</artifactId>
   <name>JCT acceptance tests for Google AutoFactory</name>
+  <description>Acceptance test components.</description>
 
   <properties>
     <auto-factory.version>1.0.1</auto-factory.version>
diff --git a/acceptance-tests/acceptance-tests-google-auto-service/pom.xml b/acceptance-tests/acceptance-tests-google-auto-service/pom.xml
@@ -28,6 +28,7 @@
 
   <artifactId>acceptance-tests-google-auto-service</artifactId>
   <name>JCT acceptance tests for Google AutoService</name>
+  <description>Acceptance test components.</description>
 
   <properties>
     <auto-service.version>1.0.1</auto-service.version>
diff --git a/acceptance-tests/acceptance-tests-google-auto-value/pom.xml b/acceptance-tests/acceptance-tests-google-auto-value/pom.xml
@@ -28,6 +28,7 @@
 
   <artifactId>acceptance-tests-google-auto-value</artifactId>
   <name>JCT acceptance tests for Google AutoValue</name>
+  <description>Acceptance test components.</description>
 
   <properties>
     <auto-value.version>1.10.1</auto-value.version>
diff --git a/acceptance-tests/acceptance-tests-immutables/pom.xml b/acceptance-tests/acceptance-tests-immutables/pom.xml
@@ -28,6 +28,7 @@
 
   <artifactId>acceptance-tests-immutables</artifactId>
   <name>JCT acceptance tests for Immutables</name>
+  <description>Acceptance test components.</description>
 
   <properties>
     <immutables.version>2.9.3</immutables.version>
diff --git a/acceptance-tests/acceptance-tests-lombok/pom.xml b/acceptance-tests/acceptance-tests-lombok/pom.xml
@@ -28,6 +28,7 @@
 
   <artifactId>acceptance-tests-lombok</artifactId>
   <name>JCT acceptance tests for Lombok</name>
+  <description>Acceptance test components.</description>
 
   <properties>
     <lombok.version>1.18.24</lombok.version>
diff --git a/acceptance-tests/acceptance-tests-manifold-systems/pom.xml b/acceptance-tests/acceptance-tests-manifold-systems/pom.xml
@@ -28,6 +28,7 @@
 
   <artifactId>acceptance-tests-manifold-systems</artifactId>
   <name>JCT acceptance tests for Manifold Systems</name>
+  <description>Acceptance test components.</description>
 
   <properties>
     <manifold.version>2022.1.34</manifold.version>
diff --git a/acceptance-tests/acceptance-tests-mapstruct/pom.xml b/acceptance-tests/acceptance-tests-mapstruct/pom.xml
@@ -28,6 +28,7 @@
 
   <artifactId>acceptance-tests-mapstruct</artifactId>
   <name>JCT acceptance tests for MapStruct</name>
+  <description>Acceptance test components.</description>
 
   <properties>
     <mapstruct.version>1.5.3.Final</mapstruct.version>
diff --git a/acceptance-tests/acceptance-tests-micronaut/pom.xml b/acceptance-tests/acceptance-tests-micronaut/pom.xml
@@ -28,6 +28,7 @@
 
   <artifactId>acceptance-tests-micronaut</artifactId>
   <name>JCT acceptance tests for Micronaut</name>
+  <description>Acceptance test components.</description>
 
   <properties>
     <micronaut.version>3.8.0</micronaut.version>
diff --git a/acceptance-tests/acceptance-tests-serviceloader-jpms/pom.xml b/acceptance-tests/acceptance-tests-serviceloader-jpms/pom.xml
@@ -28,6 +28,7 @@
 
   <artifactId>acceptance-tests-serviceloader-jpms</artifactId>
   <name>JCT acceptance tests for a service loader API (JPMS)</name>
+  <description>Acceptance test components.</description>
 
   <dependencies>
     <dependency>
diff --git a/acceptance-tests/acceptance-tests-serviceloader/pom.xml b/acceptance-tests/acceptance-tests-serviceloader/pom.xml
@@ -28,6 +28,7 @@
 
   <artifactId>acceptance-tests-serviceloader</artifactId>
   <name>JCT acceptance tests for a service loader API</name>
+  <description>Acceptance test components.</description>
 
   <dependencies>
     <dependency>
diff --git a/acceptance-tests/acceptance-tests-spring/pom.xml b/acceptance-tests/acceptance-tests-spring/pom.xml
@@ -28,6 +28,7 @@
 
   <artifactId>acceptance-tests-spring</artifactId>
   <name>JCT acceptance tests for Spring Framework 6</name>
+  <description>Acceptance test components.</description>
 
   <properties>
     <spring-boot.version>3.0.1</spring-boot.version>
diff --git a/acceptance-tests/pom.xml b/acceptance-tests/pom.xml
@@ -30,6 +30,7 @@
   <packaging>pom</packaging>
 
   <name>JCT acceptance test parent project</name>
+  <description>Acceptance test components.</description>
 
   <modules>
     <module>acceptance-tests-avaje-inject</module>
@@ -58,6 +59,7 @@
     <maven.javadoc.skip>true</maven.javadoc.skip>
     <maven.release.skip>true</maven.release.skip>
     <skip-dependency-scan>true</skip-dependency-scan>
+    <skipNexusStagingDeployMojo>true</skipNexusStagingDeployMojo>
   </properties>
 
   <dependencyManagement>
diff --git a/pom.xml b/pom.xml
@@ -621,6 +621,7 @@
             <keepStagingRepositoryOnFailure>true</keepStagingRepositoryOnFailure>
             <nexusUrl>https://s01.oss.sonatype.org/</nexusUrl>
             <serverId>ossrh</serverId>
+            <skipLocalStaging>true</skipLocalStaging>
             <skipStaging>true</skipStaging>
             <updateReleaseInfo>true</updateReleaseInfo>
           </configuration>
