Fix lua building

Author: shehzan10

CMakeModules/build_lua.cmake

@@ -2,7 +2,7 @@ INCLUDE(ExternalProject)
 
 SET(prefix ${CMAKE_BINARY_DIR}/third_party/lua)
 
-SET(lua_location "${prefix}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}lua${CMAKE_STATIC_LIBRARY_SUFFIX}")
+SET(lua_location "${prefix}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}lua${CMAKE_SHARED_LIBRARY_SUFFIX}")
 IF(CMAKE_VERSION VERSION_LESS 3.2)
     IF(CMAKE_GENERATOR MATCHES "Ninja")
         MESSAGE(WARNING "Building forge with Ninja has known issues with CMake older than 3.2")
@@ -13,7 +13,13 @@ ELSE()
 ENDIF()
 
 IF(WIN32)
-    ADD_DEFINITIONS("-DLUA_DL_DLL")
+    SET(LUA_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DLUA_DL_DLL")
+    SET(LUA_C_FLAGS "${CMAKE_C_FLAGS} -DLUA_DL_DLL")
+    SET(LUA_BUILD_AS_DLL ON)
+ELSE()
+    SET(LUA_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
+    SET(LUA_C_FLAGS "${CMAKE_C_FLAGS}")
+    SET(LUA_BUILD_AS_DLL OFF)
 ENDIF()
 
 # FIXME Tag forge correctly during release
@@ -29,17 +35,17 @@ ExternalProject_Add(
     -DCMAKE_SOURCE_DIR:PATH=<SOURCE_DIR>
     -DCMAKE_CXX_COMPILER:FILEPATH=${CMAKE_CXX_COMPILER}
     -DCMAKE_C_COMPILER:FILEPATH=${CMAKE_C_COMPILER}
-    -DCMAKE_CXX_FLAGS:STRING=${CMAKE_CXX_FLAGS}
-    -DCMAKE_C_FLAGS:STRING=${CMAKE_C_FLAGS}
+    -DCMAKE_CXX_FLAGS:STRING=${LUA_CXX_FLAGS}
+    -DCMAKE_C_FLAGS:STRING=${LUA_C_FLAGS}
     -DCMAKE_BUILD_TYPE:STRING=${CMAKE_BUILD_TYPE}
     -DCMAKE_INSTALL_PREFIX:PATH=<INSTALL_DIR>
     -DBUILD_SHARED_LIBS=ON
-    -DLUA_BUILD_AS_DLL=ON
+    -DLUA_BUILD_AS_DLL=${LUA_BUILD_AS_DLL}
     ${byproducts}
     )
 
 ExternalProject_Get_Property(lua-ext install_dir)
-ADD_LIBRARY(lua IMPORTED STATIC)
+ADD_LIBRARY(lua IMPORTED SHARED)
 SET_TARGET_PROPERTIES(lua PROPERTIES IMPORTED_LOCATION ${lua_location})
 ADD_DEPENDENCIES(lua lua-ext)
 SET(LUA_INCLUDE_DIR ${install_dir}/include)