Add deprecation warnings for `send()`, `transfer()`, ABI coder v1, contract comparisons, virtual modifiers and `memory-safe-assembly` comment #16174

matheusaaguiar · 2025-08-19T04:20:24Z

Partially solves #15795.
Deprecation warnings for:

comparison operators on contract type Reconsider operators on ContractType #11700.
.send and .transfer Remove .send and .transfer. #7455.
ABI coder v1 Remove ABIEncoderV1 #11323.
virtual modifiers Disallow virtual modifiers #12483.
/// @solidity memory-safe-assembly natspec comment.

cameel · 2025-08-19T17:47:04Z

Just a quick heads up: note that the issues you listed in the description should not be closed when this PR is merged. They're about feature removals and adding a warning is just an intermediate step, not a complete solution.

docs/contracts/functions.rst

clonker · 2025-10-28T07:52:03Z

docs/contracts/functions.rst

 call to the contract with empty calldata. This is the function that is executed
 on plain Ether transfers (e.g. via ``.send()`` or ``.transfer()``). If no such
 function exists, but a payable :ref:`fallback function <fallback-function>`


Perhaps not in this PR but I think we will have to go through the docs regarding send and transfer and see where we have to update them wrt best practices regarding send and transfer

Yeah, I was thinking about this. We will need to update parts of the docs to reflect the deprecation of these functionalities.
I guess a separate PR for that would be better for organization purposes.

Yeah. It has to be done before we release though. :)

docs/contracts/functions.rst

docs/contracts/inheritance.rst

docs/examples/blind-auction.rst

docs/types/value-types.rst

docs/assembly.rst

libsolidity/analysis/TypeChecker.cpp

clonker · 2025-10-28T08:37:16Z

Please go over the docs again, we will deprecate things before 0.9 and with 0.9 or a later version they will be removed. So "Note that XYZ will be deprecated in 0.9" should be "Note that XYZ are deprecated and scheduled for removal in 0.9".

I find it a bit problematic to show deprecated code in the examples. This should be updated to be according to best practices. I am not sure if this PR is the right place for it, but if you find it's not, it should be done in a follow-up.

Generally I'd have liked that alongside the .. warning of a deprecation you not only say that it is deprecated but also give a hint what to do instead. For example:

.. warning::
    The following patterns are deprecated and will be removed in v0.9:

    - ``address.send()`` - Use ... instead
    - ``address.transfer()`` - Use ...

Also the code-emitted warnings have to be updated to reflect that things are deprecated now and will be removed in a future breaking release. Please present alternatives there (like for the send stuff to use call) and if possible it would be great to provide a link to the docs where this is described. Otherwise users are left stranded. Think what you would like to see if a compiler presents you with a deprecation warning.

Implementation-wise it looks good.

matheusaaguiar

I have changed according to most of your suggestions @clonker. There are still some places where we need to properly rewrite or erase the docs to reflect the deprecation in the examples (send/transfer and virtual modifiers).

docs/control-structures.rst

docs/security-considerations.rst

clonker

some more comments :)

docs/contracts/functions.rst

docs/types/value-types.rst

docs/assembly.rst

docs/control-structures.rst

docs/security-considerations.rst

libsolidity/analysis/TypeChecker.cpp

clonker

Unfortunately still some things to do:

Here we have documentation of send and transfer but no mention that they're deprecated:

docs/units-and-global-variables.rst (Members of Address Types section)
docs/cheatsheet.rst (Address Related section)

Hope I didn't miss anything else in the documentation beyond these two. Wouldn't hurt to double-check.

Then there needs to be a changelog entry. We should probably also start a docs/090-breaking-changes.rst and document this there.

libsolidity/analysis/TypeChecker.cpp

test/libsolidity/syntaxTests/viewPureChecker/eof/builtin_functions.sol

matheusaaguiar · 2025-10-31T18:11:40Z

We should probably also start a docs/090-breaking-changes.rst and document this there.

I have started to do that, but will submit in a separate PR along other doc revisions, if you think it is ok.

I created #16274 to track the work needed in order to update the docs for the breaking changes of v.0.9.

clonker

Thanks for creating the tracking issue! Some more minor things I found in a final pass.

docs/contracts/functions.rst

docs/assembly.rst

libsolidity/analysis/TypeChecker.cpp

Changelog.md

libsolidity/analysis/DocStringTagParser.cpp

docs/assembly.rst

docs/cheatsheet.rst

docs/contracts/inheritance.rst

cameel · 2025-12-02T19:28:13Z

docs/control-structures.rst

    The caller always retains at least 1/64th of the gas in a call and thus
    even if the called contract goes out of gas, the caller still
-    has some gas left.
+    has some gas left.


What changed here?

No clue, maybe it needs a rebase.

Or maybe it's a newline at the end of the file.

docs/examples/safe-remote.rst

docs/examples/blind-auction.rst

docs/security-considerations.rst

docs/units-and-global-variables.rst

test/libsolidity/syntaxTests/viewPureChecker/eof/builtin_functions.sol

docs/contracts/functions.rst

docs/types/value-types.rst

docs/units-and-global-variables.rst

test/libsolidity/syntaxTests/abiEncoder/conflicting_settings_reverse.sol

cameel · 2025-12-02T22:49:27Z

docs/types/value-types.rst

-.. note::
-    Prior to homestead, only a limited variant called ``callcode`` was available that did not provide access to the original ``msg.sender`` and ``msg.value`` values. This function was removed in version 0.5.0.
+    .. note::
+        Prior to homestead, only a limited variant called ``callcode`` was available that did not provide access to the original ``msg.sender`` and ``msg.value`` values. This function was removed in version 0.5.0.

-Since byzantium ``staticcall`` can be used as well. This is basically the same as ``call``, but will revert if the called function modifies the state in any way.
+        Since byzantium ``staticcall`` can be used as well. This is basically the same as ``call``, but will revert if the called function modifies the state in any way.

-All three functions ``call``, ``delegatecall`` and ``staticcall`` are very low-level functions and should only be used as a *last resort* as they break the type-safety of Solidity.
+        All three functions ``call``, ``delegatecall`` and ``staticcall`` are very low-level functions and should only be used as a *last resort* as they break the type-safety of Solidity.

-The ``gas`` option is available on all three methods, while the ``value`` option is only available
-on ``call``.
+        The ``gas`` option is available on all three methods, while the ``value`` option is only available
+        on ``call``.


Just noticed that the indent here is too long. The text that was originally under the note is now inside it due to this.

cameel · 2025-12-02T22:50:30Z

docs/units-and-global-variables.rst


 Members of Address Types
 ------------------------
+These members are explained in more detail in the section on :ref:`members of address <members-of-addresses>`


Suggested change

These members are explained in more detail in the section on :ref:`members of address <members-of-addresses>`

These members are explained in more detail in the section on :ref:`members of address <members-of-addresses>`.

cameel

Approving since this pretty much ready to go, just two minor tweaks remain.

…ory-safe-assembly, send and transfer functions, and virtual modifiers.

matheusaaguiar · 2025-12-02T23:13:58Z

@cameel I think everything is fixed now. I rebased and squashed the commits.
Please approve again.

matheusaaguiar force-pushed the deprecation_warnings branch 3 times, most recently from 3c00eb6 to f052fe2 Compare August 20, 2025 22:52

matheusaaguiar force-pushed the deprecation_warnings branch 2 times, most recently from 6d32b8c to 2531e30 Compare September 3, 2025 02:24

matheusaaguiar force-pushed the deprecation_warnings branch from 2531e30 to cb21835 Compare September 11, 2025 18:43

github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Sep 26, 2025

matheusaaguiar removed the stale The issue/PR was marked as stale because it has been open for too long. label Sep 27, 2025

matheusaaguiar force-pushed the deprecation_warnings branch from cb21835 to 0c67bef Compare September 27, 2025 12:55

github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Oct 12, 2025

matheusaaguiar removed the stale The issue/PR was marked as stale because it has been open for too long. label Oct 13, 2025

matheusaaguiar force-pushed the deprecation_warnings branch from 0c67bef to 2cf221d Compare October 13, 2025 17:21

matheusaaguiar requested a review from clonker October 27, 2025 14:52

matheusaaguiar force-pushed the deprecation_warnings branch from 2cf221d to ab2e083 Compare October 27, 2025 14:53

clonker reviewed Oct 28, 2025

View reviewed changes

matheusaaguiar force-pushed the deprecation_warnings branch 4 times, most recently from c203f66 to 3fb9ccd Compare October 29, 2025 12:44

matheusaaguiar commented Oct 29, 2025

View reviewed changes

docs/control-structures.rst Show resolved Hide resolved

docs/security-considerations.rst Show resolved Hide resolved

clonker reviewed Oct 30, 2025

View reviewed changes

matheusaaguiar force-pushed the deprecation_warnings branch from 88b472b to db310b6 Compare October 30, 2025 16:33

clonker requested changes Oct 31, 2025

View reviewed changes

libsolidity/analysis/TypeChecker.cpp Outdated Show resolved Hide resolved

test/libsolidity/syntaxTests/viewPureChecker/eof/builtin_functions.sol Show resolved Hide resolved

matheusaaguiar force-pushed the deprecation_warnings branch 2 times, most recently from b59a2b4 to 86da905 Compare October 31, 2025 17:44

clonker reviewed Nov 1, 2025

View reviewed changes

matheusaaguiar force-pushed the deprecation_warnings branch from c053734 to a260c59 Compare November 3, 2025 14:07

matheusaaguiar force-pushed the deprecation_warnings branch from d57fae4 to 7e86c8e Compare November 17, 2025 16:12

matheusaaguiar mentioned this pull request Nov 19, 2025

Replace transfer (deprecated) occurrences with call in smt tests #16291

Open

matheusaaguiar force-pushed the deprecation_warnings branch from c55108b to d97549f Compare November 19, 2025 16:36

cameel reviewed Nov 25, 2025

View reviewed changes

libsolidity/analysis/DocStringTagParser.cpp Outdated Show resolved Hide resolved

cameel changed the title ~~Add various deprecation warnings~~ Add deprecation warnings for send(), transfer(), ABI coder v1, contract comparisons, virtual modifiers and memory-safe-assembly comment Nov 26, 2025

matheusaaguiar force-pushed the deprecation_warnings branch from 64e40cf to beeeaae Compare December 2, 2025 17:17

cameel modified the milestones: 0.8.32, 0.8.31 Dec 2, 2025

cameel requested changes Dec 2, 2025

View reviewed changes

matheusaaguiar force-pushed the deprecation_warnings branch from beeeaae to d48aea9 Compare December 2, 2025 21:19

matheusaaguiar requested a review from cameel December 2, 2025 21:22

cameel reviewed Dec 2, 2025

View reviewed changes

argotorg deleted a comment from github-actions bot Dec 2, 2025

matheusaaguiar requested a review from cameel December 2, 2025 22:40

cameel reviewed Dec 2, 2025

View reviewed changes

cameel previously approved these changes Dec 2, 2025

View reviewed changes

matheusaaguiar added 3 commits December 2, 2025 20:10

Emit deprecation warnings for abi coder v1, contract comparisons, mem…

f4173b2

…ory-safe-assembly, send and transfer functions, and virtual modifiers.

Update docs

dbeb876

zeppelin ext test workaround

b60f110

matheusaaguiar dismissed cameel’s stale review via b60f110 December 2, 2025 23:12

matheusaaguiar force-pushed the deprecation_warnings branch from 1d5585d to b60f110 Compare December 2, 2025 23:12

cameel approved these changes Dec 2, 2025

View reviewed changes

cameel enabled auto-merge December 2, 2025 23:38

cameel merged commit ac77d12 into develop Dec 2, 2025
81 checks passed

cameel deleted the deprecation_warnings branch December 2, 2025 23:58

	These members are explained in more detail in the section on :ref:`members of address <members-of-addresses>`
	These members are explained in more detail in the section on :ref:`members of address <members-of-addresses>`.

Add deprecation warnings for send(), transfer(), ABI coder v1, contract comparisons, virtual modifiers and memory-safe-assembly comment #16174

Add deprecation warnings for send(), transfer(), ABI coder v1, contract comparisons, virtual modifiers and memory-safe-assembly comment #16174

Conversation

matheusaaguiar commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cameel commented Aug 19, 2025

Uh oh!

Uh oh!

clonker Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

matheusaaguiar Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

clonker Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

clonker commented Oct 28, 2025

Uh oh!

matheusaaguiar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

clonker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

clonker left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

matheusaaguiar commented Oct 31, 2025

Uh oh!

clonker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cameel Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

matheusaaguiar Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

matheusaaguiar Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Add deprecation warnings for `send()`, `transfer()`, ABI coder v1, contract comparisons, virtual modifiers and `memory-safe-assembly` comment #16174

Add deprecation warnings for `send()`, `transfer()`, ABI coder v1, contract comparisons, virtual modifiers and `memory-safe-assembly` comment #16174

matheusaaguiar commented Aug 19, 2025 •

edited

Loading

clonker left a comment •

edited

Loading

cameel Dec 2, 2025 •

edited

Loading