From f4b26d0d41fb156f1fe16af7ab6df2f384880888 Mon Sep 17 00:00:00 2001 From: Marcus Carneiro Date: Fri, 17 Oct 2025 09:08:39 -0700 Subject: [PATCH 1/2] fix: Remove incorrect yaml.LiteralStyle from helm values write-back This commit fixes a regression introduced between v0.14.0 and v0.17.0 where helm values files would be emptied or corrupted when using git write-back with helmvalues: target. The issue was caused by setting `Style: yaml.LiteralStyle` on the root MappingNode when initializing an empty helm values structure. The LiteralStyle is intended for scalar string values with block style (|), not for mapping nodes. This caused the YAML encoder to produce incorrect or empty output when marshaling the structure back to YAML. This regression affected users with multi-source applications using separate image-name and image-tag annotations with helmvalues write-back, resulting in their values files being deleted on update. Fixes: Regression between v0.14.0 and v0.17.0 Testing: All existing tests pass with this change Signed-off-by: DeZin7 --- pkg/argocd/update.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/argocd/update.go b/pkg/argocd/update.go index 65c79c05..822e33aa 100644 --- a/pkg/argocd/update.go +++ b/pkg/argocd/update.go @@ -498,7 +498,6 @@ func marshalParamsOverride(app *v1alpha1.Application, originalData []byte) ([]by Kind: yaml.MappingNode, Tag: "!!map", Content: []*yaml.Node{}, - Style: yaml.LiteralStyle, }, }, } From cb9ddf51d711dc804de727e81974ddda516127b1 Mon Sep 17 00:00:00 2001 From: Cheng Fang Date: Mon, 20 Oct 2025 23:36:56 +0800 Subject: [PATCH 2/2] chore(docker): optimize docker build process (#1285) Signed-off-by: Cheng Fang Signed-off-by: DeZin7 --- .dockerignore | 13 +++++++++++++ Dockerfile | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/.dockerignore b/.dockerignore index 06bd9b3e..6e4d4b26 100644 --- a/.dockerignore +++ b/.dockerignore @@ -1,9 +1,22 @@ +.github .vscode/ .idea/ .DS_Store +bin/ dist/ +**/docs/ +**/vendor/ +registry-scanner/config +registry-scanner/hack +registry-scanner/test +scripts/ +test/e2e +test/testdata +test/utils *.iml # delve debug binaries cmd/**/debug debug.test **/coverage.out +**/CHANGELOG.md +**/README.md diff --git a/Dockerfile b/Dockerfile index b04139ce..3d7cf45f 100644 --- a/Dockerfile +++ b/Dockerfile @@ -4,7 +4,7 @@ RUN mkdir -p /src/argocd-image-updater WORKDIR /src/argocd-image-updater # cache dependencies as a layer for faster rebuilds COPY go.mod go.sum ./ -COPY registry-scanner ./ +COPY registry-scanner/go.mod registry-scanner/go.sum ./registry-scanner/ RUN go mod download COPY . .