Extract constant openssl x509 parameters into variable to avoid duplication by copy.

Author: aentinger

tools/nina-fw-create-roots.sh

@@ -19,82 +19,84 @@ do
   is_cybertrust=$(openssl x509 -in $filename -text -nocert | grep "O = \"Cybertrust, Inc\"")
   is_usertrust=$(openssl x509 -in $filename -text -nocert | grep "O = The USERTRUST Network")
 
+  openssl_opts="-text -certopt no_header,no_pubkey,no_subject,no_issuer,no_signame,no_version,no_serial,no_validity,no_extensions,no_sigdump,no_aux,no_extensions"
+
   if [ ! -z "$is_amazon" ]
   then
     echo $is_amazon
-    openssl x509 -in $filename -text -certopt no_header,no_pubkey,no_subject,no_issuer,no_signame,no_version,no_serial,no_validity,no_extensions,no_sigdump,no_aux,no_extensions >> roots.pem
+    openssl x509 -in $filename $openssl_opts >> roots.pem
   fi
 
   if [ ! -z "$is_google" ]
   then
     echo $is_google
-    openssl x509 -in $filename -text -certopt no_header,no_pubkey,no_subject,no_issuer,no_signame,no_version,no_serial,no_validity,no_extensions,no_sigdump,no_aux,no_extensions >> roots.pem
+    openssl x509 -in $filename $openssl_opts >> roots.pem
   fi
 
   if [ ! -z "$is_comodo_uppercase" ]
   then
     echo $is_comodo_uppercase
-    openssl x509 -in $filename -text -certopt no_header,no_pubkey,no_subject,no_issuer,no_signame,no_version,no_serial,no_validity,no_extensions,no_sigdump,no_aux,no_extensions >> roots.pem
+    openssl x509 -in $filename $openssl_opts >> roots.pem
   fi
 
   if [ ! -z "$is_comodo" ]
   then
     echo $is_comodo
-    openssl x509 -in $filename -text -certopt no_header,no_pubkey,no_subject,no_issuer,no_signame,no_version,no_serial,no_validity,no_extensions,no_sigdump,no_aux,no_extensions >> roots.pem
+    openssl x509 -in $filename $openssl_opts >> roots.pem
   fi
 
   if [ ! -z "$is_digicert" ]
   then
     echo $is_digicert
-    openssl x509 -in $filename -text -certopt no_header,no_pubkey,no_subject,no_issuer,no_signame,no_version,no_serial,no_validity,no_extensions,no_sigdump,no_aux,no_extensions >> roots.pem
+    openssl x509 -in $filename $openssl_opts >> roots.pem
   fi
 
   if [ ! -z "$is_isrg" ]
   then
     echo $is_isrg
-    openssl x509 -in $filename -text -certopt no_header,no_pubkey,no_subject,no_issuer,no_signame,no_version,no_serial,no_validity,no_extensions,no_sigdump,no_aux,no_extensions >> roots.pem
+    openssl x509 -in $filename $openssl_opts >> roots.pem
   fi
 
   if [ ! -z "$is_verisign" ]
   then
     echo $is_verisign
-    openssl x509 -in $filename -text -certopt no_header,no_pubkey,no_subject,no_issuer,no_signame,no_version,no_serial,no_validity,no_extensions,no_sigdump,no_aux,no_extensions >> roots.pem
+    openssl x509 -in $filename $openssl_opts >> roots.pem
   fi
 
   if [ ! -z "$is_baltimore" ]
   then
     echo $is_baltimore
-    openssl x509 -in $filename -text -certopt no_header,no_pubkey,no_subject,no_issuer,no_signame,no_version,no_serial,no_validity,no_extensions,no_sigdump,no_aux,no_extensions >> roots.pem
+    openssl x509 -in $filename $openssl_opts >> roots.pem
   fi
 
   if [ ! -z "$is_globalsign" ]
   then
     echo $is_globalsign
-    openssl x509 -in $filename -text -certopt no_header,no_pubkey,no_subject,no_issuer,no_signame,no_version,no_serial,no_validity,no_extensions,no_sigdump,no_aux,no_extensions >> roots.pem
+    openssl x509 -in $filename $openssl_opts >> roots.pem
   fi
 
   if [ ! -z "$is_starfield" ]
   then
     echo $is_starfield
-    openssl x509 -in $filename -text -certopt no_header,no_pubkey,no_subject,no_issuer,no_signame,no_version,no_serial,no_validity,no_extensions,no_sigdump,no_aux,no_extensions >> roots.pem
+    openssl x509 -in $filename $openssl_opts >> roots.pem
   fi
 
   if [ ! -z "$is_dst" ]
   then
     echo $is_dst
-    openssl x509 -in $filename -text -certopt no_header,no_pubkey,no_subject,no_issuer,no_signame,no_version,no_serial,no_validity,no_extensions,no_sigdump,no_aux,no_extensions >> roots.pem
+    openssl x509 -in $filename $openssl_opts >> roots.pem
   fi
 
   if [ ! -z "$is_cybertrust" ]
   then
     echo $is_cybertrust
-    openssl x509 -in $filename -text -certopt no_header,no_pubkey,no_subject,no_issuer,no_signame,no_version,no_serial,no_validity,no_extensions,no_sigdump,no_aux,no_extensions >> roots.pem
+    openssl x509 -in $filename $openssl_opts >> roots.pem
   fi
 
   if [ ! -z "$is_usertrust" ]
   then
     echo $is_usertrust
-    openssl x509 -in $filename -text -certopt no_header,no_pubkey,no_subject,no_issuer,no_signame,no_version,no_serial,no_validity,no_extensions,no_sigdump,no_aux,no_extensions >> roots.pem
+    openssl x509 -in $filename $openssl_opts >> roots.pem
   fi
 
 done