[PXCT-81] Nano Matter - Technical check with 2.1.0 Silabs Core and User Manual Update #2297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
jumping to review this |
jcarolinares
requested changes
Dec 2, 2024
Contributor
jcarolinares
left a comment
jcarolinares
left a comment
There was a problem hiding this comment.
Small feedback added, this looks promising, please take a look at the comments and solve the "checked" as a way to make both sure we double checked the new items, ping me when you are ready about the suggestion/feedback left @mcmchris
content/hardware/03.nano/boards/nano-matter/tutorials/user-manual/assets/adc-input-2.png
Show resolved
Hide resolved
content/hardware/03.nano/boards/nano-matter/tutorials/user-manual/assets/alexa-matter.gif
Show resolved
Hide resolved
content/hardware/03.nano/boards/nano-matter/tutorials/user-manual/assets/apple-matter.gif
Show resolved
Hide resolved
content/hardware/03.nano/boards/nano-matter/tutorials/user-manual/assets/architecture-2.png
Show resolved
Hide resolved
content/hardware/03.nano/boards/nano-matter/tutorials/user-manual/assets/castellated-2.png
Show resolved
Hide resolved
content/hardware/03.nano/boards/nano-matter/tutorials/user-manual/content.md
Outdated
Show resolved
Hide resolved
content/hardware/03.nano/boards/nano-matter/tutorials/user-manual/content.md
Outdated
Show resolved
Hide resolved
content/hardware/03.nano/boards/nano-matter/tutorials/user-manual/content.md
Outdated
Show resolved
Hide resolved
content/hardware/03.nano/boards/nano-matter/tutorials/user-manual/content.md
Outdated
Show resolved
Hide resolved
content/hardware/03.nano/boards/nano-matter/tutorials/user-manual/content.md
Show resolved
Hide resolved
jcarolinares
changed the title
Collaborator
Author
|
@jcarolinares thanks for your feedback, I applied your suggestions! |
jcarolinares
approved these changes
Dec 3, 2024
Contributor
jcarolinares
left a comment
jcarolinares
left a comment
There was a problem hiding this comment.
Feedback applied, ready to merge @mcmchris
Collaborator
Author
|
Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Changes
Contribution Guidelines