Skip to content

Conversation

@mcmchris
Copy link
Collaborator

@mcmchris mcmchris commented Nov 22, 2024

What This PR Changes

  • Technical check with 2.1.0 Silabs Core and User Manual Update

Contribution Guidelines

@jcarolinares jcarolinares self-requested a review December 2, 2024 15:10
@jcarolinares
Copy link
Contributor

jumping to review this

Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small feedback added, this looks promising, please take a look at the comments and solve the "checked" as a way to make both sure we double checked the new items, ping me when you are ready about the suggestion/feedback left @mcmchris

@jcarolinares jcarolinares changed the title [PXCT-81] Technical check with 2.1.0 Silabs Core and User Manual Update [PXCT-81] Nano Matter - Technical check with 2.1.0 Silabs Core and User Manual Update Dec 3, 2024
@jcarolinares jcarolinares changed the base branch from main to launch/nano-matter December 3, 2024 10:33
@mcmchris
Copy link
Collaborator Author

mcmchris commented Dec 3, 2024

@jcarolinares thanks for your feedback, I applied your suggestions!

Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback applied, ready to merge @mcmchris

@mcmchris
Copy link
Collaborator Author

mcmchris commented Dec 3, 2024

Merging!

@mcmchris mcmchris merged commit cf4d488 into launch/nano-matter Dec 3, 2024
4 checks passed
@mcmchris mcmchris deleted the mcmchris/nano-matter/launch-user-manual-update branch December 3, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants