Change sketches report key from "fqbn" to "board"

Arduino CLI's issue tracker has shown that users have a lot of trouble with FQBN. For this reason, Arduino CLI will soon support the use of "board aliases" in place of FQBN. This is likely to become more commonly used than the FQBN. For this reason, it makes sense to change the key name to match the expected usage. "board" still applies well even if the value is an FQBN, whereas the reverse is not so.

The move to reporting data for all sketches already causes a breaking change to the report, so updating the key name does no additional harm.

Author: per1234

compilesketches/compilesketches.py

@@ -80,7 +80,7 @@ class RunCommandOutput(enum.Enum):
     board_manager_platforms_path = arduino_cli_data_directory_path.joinpath("packages")
 
     class ReportKeys:
-        fqbn = "fqbn"
+        board = "board"
         commit_hash = "commit_hash"
         commit_url = "commit_url"
         compilation_success = "compilation_success"
@@ -952,7 +952,7 @@ def get_sketches_report(self, sketch_report_list):
         current_git_ref = get_head_commit_hash()
 
         sketches_report = {
-            self.ReportKeys.fqbn: self.fqbn,
+            self.ReportKeys.board: self.fqbn,
             self.ReportKeys.commit_hash: current_git_ref,
             self.ReportKeys.commit_url: ("https://github.com/"
                                          + os.environ["GITHUB_REPOSITORY"]

compilesketches/tests/test_compilesketches.py

@@ -1514,7 +1514,7 @@ def test_get_sketches_report(monkeypatch, mocker):
     compile_sketches = get_compilesketches_object(fqbn_arg=fqbn_arg)
 
     assert compile_sketches.get_sketches_report(sketch_report_list=sketch_report_list) == {
-        compilesketches.CompileSketches.ReportKeys.fqbn: compile_sketches.fqbn,
+        compilesketches.CompileSketches.ReportKeys.board: compile_sketches.fqbn,
         compilesketches.CompileSketches.ReportKeys.commit_hash: current_git_ref,
         compilesketches.CompileSketches.ReportKeys.commit_url: ("https://github.com/"
                                                                 + github_repository
@@ -1531,7 +1531,7 @@ def test_get_sketches_report(monkeypatch, mocker):
     compilesketches.CompileSketches.get_sizes_summary_report.return_value = []
 
     assert compile_sketches.get_sketches_report(sketch_report_list=sketch_report_list) == {
-        compilesketches.CompileSketches.ReportKeys.fqbn: compile_sketches.fqbn,
+        compilesketches.CompileSketches.ReportKeys.board: compile_sketches.fqbn,
         compilesketches.CompileSketches.ReportKeys.commit_hash: current_git_ref,
         compilesketches.CompileSketches.ReportKeys.commit_url: ("https://github.com/"
                                                                 + github_repository