Use standardized build data variable names

The Arduino Lint build process defines some variables with values that are used in the `--version` output. These variable
names have been modified in the standardized "template" build system, and so must also be modified here.

Author: per1234

Taskfile.yml

@@ -24,9 +24,9 @@ vars:
   LDFLAGS: >-
     -ldflags
     '
-    -X {{.CONFIGURATION_PACKAGE}}.version={{.VERSION}}
-    -X {{.CONFIGURATION_PACKAGE}}.commit={{.COMMIT}}
-    -X {{.CONFIGURATION_PACKAGE}}.buildTimestamp={{.TIMESTAMP}}
+    -X {{.CONFIGURATION_PACKAGE}}.Version={{.VERSION}}
+    -X {{.CONFIGURATION_PACKAGE}}.Commit={{.COMMIT}}
+    -X {{.CONFIGURATION_PACKAGE}}.Timestamp={{.TIMESTAMP}}
     '
   GOFLAGS: "-timeout 10m -v -coverpkg=./... -covermode=atomic"
   DOCS_VERSION: dev

internal/command/command.go

@@ -39,10 +39,10 @@ func ArduinoLint(rootCommand *cobra.Command, cliArguments []string) {
 
 	if configuration.VersionMode() {
 		if configuration.OutputFormat() == outputformat.Text {
-			if configuration.Version() == "" {
-				fmt.Print("0.0.0+" + configuration.Commit())
+			if configuration.BuildVersion() == "" {
+				fmt.Print("0.0.0+" + configuration.BuildCommit())
 			} else {
-				fmt.Print(configuration.Version())
+				fmt.Print(configuration.BuildVersion())
 			}
 			fmt.Println(" " + configuration.BuildTimestamp())
 		} else {
@@ -51,8 +51,8 @@ func ArduinoLint(rootCommand *cobra.Command, cliArguments []string) {
 				Commit         string `json:"commit"`
 				BuildTimestamp string `json:"buildTimestamp"`
 			}{
-				Version:        configuration.Version(),
-				Commit:         configuration.Commit(),
+				Version:        configuration.BuildVersion(),
+				Commit:         configuration.BuildCommit(),
 				BuildTimestamp: configuration.BuildTimestamp(),
 			}
 			versionJSON, err := json.MarshalIndent(versionObject, "", "  ")

internal/configuration/configuration.go

@@ -209,25 +209,28 @@ func VersionMode() bool {
 	return versionMode
 }
 
-var version string
+// Version is the build version.
+var Version string
 
-// Version returns the build version.
-func Version() string {
-	return version
+// BuildVersion returns the build version.
+func BuildVersion() string {
+	return Version
 }
 
-var commit string
+// Commit is the HEAD commit of the Arduino Lint repository when the application was built.
+var Commit string
 
-// Commit returns the HEAD commit of the Arduino Lint repository when the application was built.
-func Commit() string {
-	return commit
+// BuildCommit returns the HEAD commit of the Arduino Lint repository when the application was built.
+func BuildCommit() string {
+	return Commit
 }
 
-var buildTimestamp string
+// Timestamp is the timestamp of the build.
+var Timestamp string
 
 // BuildTimestamp returns the timestamp of the build.
 func BuildTimestamp() string {
-	return buildTimestamp
+	return Timestamp
 }
 
 var targetPaths paths.PathList

internal/configuration/configuration_test.go

@@ -244,16 +244,16 @@ func TestInitializeOfficial(t *testing.T) {
 }
 
 func TestVersion(t *testing.T) {
-	version = "42.1.2"
-	assert.Equal(t, version, Version())
+	Version = "42.1.2"
+	assert.Equal(t, Version, BuildVersion())
 }
 
 func TestCommit(t *testing.T) {
-	commit = "abcd"
-	assert.Equal(t, commit, Commit())
+	Commit = "abcd"
+	assert.Equal(t, Commit, BuildCommit())
 }
 
 func TestBuildTimestamp(t *testing.T) {
-	buildTimestamp = "2020-11-27T04:05:19+00:00"
-	assert.Equal(t, buildTimestamp, BuildTimestamp())
+	Timestamp = "2020-11-27T04:05:19+00:00"
+	assert.Equal(t, Timestamp, BuildTimestamp())
 }