Revert "Make --recursive flag a string input"

This reverts commit c260881.

Author: per1234

internal/cli/cli.go

@@ -35,7 +35,7 @@ func Root() *cobra.Command {
 	rootCommand.PersistentFlags().String("format", "text", "The output format can be {text|json}.")
 	rootCommand.PersistentFlags().String("library-manager", "", "Configure the rules for libraries in the Arduino Library Manager index. Can be {submit|update|false}.\nsubmit: Also run additional rules required to pass before a library is accepted for inclusion in the index.\nupdate: Also run additional rules required to pass before new releases of a library already in the index are accepted.\nfalse: Don't run any Library Manager-specific rules.")
 	rootCommand.PersistentFlags().String("project-type", "all", "Only check projects of the specified type and their subprojects. Can be {sketch|library|all}.")
-	rootCommand.PersistentFlags().String("recursive", "true", "Search path recursively for Arduino projects to check. Can be {true|false}.")
+	rootCommand.PersistentFlags().Bool("recursive", true, "Search path recursively for Arduino projects to check. Can be {true|false}.")
 	rootCommand.PersistentFlags().String("report-file", "", "Save a report on the rules to this file.")
 	rootCommand.PersistentFlags().BoolP("verbose", "v", false, "Show more information while running rules.")
 	rootCommand.PersistentFlags().Bool("version", false, "Print version and timestamp of the build.")

internal/configuration/configuration.go

@@ -81,11 +81,7 @@ func Initialize(flags *pflag.FlagSet, projectPaths []string) error {
 		return fmt.Errorf("--project-type flag value %s not valid", superprojectTypeFilterString)
 	}
 
-	recursiveString, _ := flags.GetString("recursive")
-	recursive, err = strconv.ParseBool(recursiveString)
-	if err != nil {
-		return fmt.Errorf("--recursive flag value %s not valid", recursiveString)
-	}
+	recursive, _ = flags.GetBool("recursive")
 
 	reportFilePathString, _ := flags.GetString("report-file")
 	reportFilePath = paths.New(reportFilePathString)

internal/configuration/configuration_test.go

@@ -159,9 +159,6 @@ func TestInitializeProjectType(t *testing.T) {
 func TestInitializeRecursive(t *testing.T) {
 	flags := test.ConfigurationFlags()
 
-	flags.Set("recursive", "foo")
-	assert.Error(t, Initialize(flags, projectPaths))
-
 	flags.Set("recursive", "true")
 	assert.Nil(t, Initialize(flags, projectPaths))
 	assert.True(t, Recursive())

internal/util/test/test.go

@@ -27,7 +27,7 @@ func ConfigurationFlags() *pflag.FlagSet {
 	flags.String("log-format", "text", "")
 	flags.String("log-level", "panic", "")
 	flags.String("project-type", "all", "")
-	flags.String("recursive", "true", "")
+	flags.Bool("recursive", true, "")
 	flags.String("report-file", "", "")
 	flags.Bool("verbose", false, "")
 	flags.Bool("version", false, "")