add fqbn flag for board details command (#895)

* add fqbn flag for `board details` command

Author: umbynos

cli/board/details.go

@@ -33,18 +33,21 @@ import (
 
 var tr = i18n.Tr
 var showFullDetails bool
+var fqbn string
 
 func initDetailsCommand() *cobra.Command {
 	var detailsCommand = &cobra.Command{
-		Use:     "details <FQBN>",
+		Use:     "details -b <FQBN>",
 		Short:   tr("Print details about a board."),
 		Long:    tr("Show information about a board, in particular if the board has options to be specified in the FQBN."),
-		Example: "  " + os.Args[0] + " board details arduino:avr:nano",
-		Args:    cobra.ExactArgs(1),
+		Example: "  " + os.Args[0] + " board details -b arduino:avr:nano",
+		Args:    cobra.MaximumNArgs(1),
 		Run:     runDetailsCommand,
 	}
 
 	detailsCommand.Flags().BoolVarP(&showFullDetails, "full", "f", false, tr("Show full board details"))
+	detailsCommand.Flags().StringVarP(&fqbn, "fqbn", "b", "", "Fully Qualified Board Name, e.g.: arduino:avr:uno")
+	// detailsCommand.MarkFlagRequired("fqbn") // enable once `board details <fqbn>` is removed
 
 	return detailsCommand
 }
@@ -56,9 +59,14 @@ func runDetailsCommand(cmd *cobra.Command, args []string) {
 		os.Exit(errorcodes.ErrGeneric)
 	}
 
+	// remove once `board details <fqbn>` is removed
+	if fqbn == "" && len(args) > 0 {
+		fqbn = args[0]
+	}
+
 	res, err := board.Details(context.Background(), &rpc.BoardDetailsReq{
 		Instance: inst,
-		Fqbn:     args[0],
+		Fqbn:     fqbn,
 	})
 
 	if err != nil {

i18n/data/en.po

@@ -13,28 +13,28 @@ msgstr "Aliases:"
 msgid "Available Commands:"
 msgstr "Available Commands:"
 
-#: cli/board/details.go:98
+#: cli/board/details.go:106
 msgid "Board name:"
 msgstr "Board name:"
 
-#: cli/board/details.go:100
+#: cli/board/details.go:108
 msgid "Board version:"
 msgstr "Board version:"
 
-#: cli/board/details.go:141
+#: cli/board/details.go:149
 msgid "Checksum:"
 msgstr "Checksum:"
 
-#: cli/board/details.go:55
-#: cli/board/details.go:65
+#: cli/board/details.go:58
+#: cli/board/details.go:73
 msgid "Error getting board details: %v"
 msgstr "Error getting board details: %v"
 
 #: cli/usage.go:27
 msgid "Examples:"
 msgstr "Examples:"
 
-#: cli/board/details.go:139
+#: cli/board/details.go:147
 msgid "File:"
 msgstr "File:"
 
@@ -46,87 +46,87 @@ msgstr "Flags:"
 msgid "Global Flags:"
 msgstr "Global Flags:"
 
-#: cli/board/details.go:111
+#: cli/board/details.go:119
 msgid "Identification properties:"
 msgstr "Identification properties:"
 
-#: cli/board/details.go:138
+#: cli/board/details.go:146
 msgid "OS:"
 msgstr "OS:"
 
-#: cli/board/details.go:104
+#: cli/board/details.go:112
 msgid "Official Arduino board:"
 msgstr "Official Arduino board:"
 
-#: cli/board/details.go:150
+#: cli/board/details.go:158
 msgid "Option:"
 msgstr "Option:"
 
-#: cli/board/details.go:120
+#: cli/board/details.go:128
 msgid "Package URL:"
 msgstr "Package URL:"
 
-#: cli/board/details.go:119
+#: cli/board/details.go:127
 msgid "Package maintainer:"
 msgstr "Package maintainer:"
 
-#: cli/board/details.go:118
+#: cli/board/details.go:126
 msgid "Package name:"
 msgstr "Package name:"
 
-#: cli/board/details.go:122
+#: cli/board/details.go:130
 msgid "Package online help:"
 msgstr "Package online help:"
 
-#: cli/board/details.go:121
+#: cli/board/details.go:129
 msgid "Package website:"
 msgstr "Package website:"
 
-#: cli/board/details.go:128
+#: cli/board/details.go:136
 msgid "Platform URL:"
 msgstr "Platform URL:"
 
-#: cli/board/details.go:127
+#: cli/board/details.go:135
 msgid "Platform architecture:"
 msgstr "Platform architecture:"
 
-#: cli/board/details.go:126
+#: cli/board/details.go:134
 msgid "Platform category:"
 msgstr "Platform category:"
 
-#: cli/board/details.go:131
+#: cli/board/details.go:139
 msgid "Platform checksum:"
 msgstr "Platform checksum:"
 
-#: cli/board/details.go:129
+#: cli/board/details.go:137
 msgid "Platform file name:"
 msgstr "Platform file name:"
 
-#: cli/board/details.go:125
+#: cli/board/details.go:133
 msgid "Platform name:"
 msgstr "Platform name:"
 
-#: cli/board/details.go:130
+#: cli/board/details.go:138
 msgid "Platform size (bytes):"
 msgstr "Platform size (bytes):"
 
-#: cli/board/details.go:40
+#: cli/board/details.go:41
 msgid "Print details about a board."
 msgstr "Print details about a board."
 
-#: cli/board/details.go:135
+#: cli/board/details.go:143
 msgid "Required tool:"
 msgstr "Required tool:"
 
-#: cli/board/details.go:47
+#: cli/board/details.go:48
 msgid "Show full board details"
 msgstr "Show full board details"
 
-#: cli/board/details.go:41
+#: cli/board/details.go:42
 msgid "Show information about a board, in particular if the board has options to be specified in the FQBN."
 msgstr "Show information about a board, in particular if the board has options to be specified in the FQBN."
 
-#: cli/board/details.go:140
+#: cli/board/details.go:148
 msgid "Size (bytes):"
 msgstr "Size (bytes):"