feat: Add test for cache clean

Clean cache files with command `arduino-cli cache clean`.

Author: howjmay

cli/cache/clean.go

@@ -17,14 +17,12 @@ package cache
 
 import (
 	"os"
-	"path/filepath"
-	"runtime"
 
 	"github.com/arduino/arduino-cli/cli/errorcodes"
 	"github.com/arduino/arduino-cli/cli/feedback"
-	"github.com/arduino/go-win32-utils"
 	"github.com/sirupsen/logrus"
 	"github.com/spf13/cobra"
+	"github.com/spf13/viper"
 )
 
 func initCleanCommand() *cobra.Command {
@@ -42,34 +40,10 @@ func initCleanCommand() *cobra.Command {
 func runCleanCommand(cmd *cobra.Command, args []string) {
 	logrus.Info("Executing `arduino cache clean`")
 
-	cachePath := getDefaultArduinoDataDir() + "/staging"
+	cachePath := viper.GetString("directories.Downloads")
 	err := os.RemoveAll(cachePath)
 	if err != nil {
 		feedback.Errorf("Error cleaning caches: %v", err)
 		os.Exit(errorcodes.ErrGeneric)
 	}
 }
-
-func getDefaultArduinoDataDir() string {
-	userHomeDir, err := os.UserHomeDir()
-	if err != nil {
-		feedback.Errorf("Unable to get user home dir: %v", err)
-		return "."
-	}
-
-	switch runtime.GOOS {
-	case "linux":
-		return filepath.Join(userHomeDir, ".arduino15")
-	case "darwin":
-		return filepath.Join(userHomeDir, "Library", "Arduino15")
-	case "windows":
-		localAppDataPath, err := win32.GetLocalAppDataFolder()
-		if err != nil {
-			feedback.Errorf("Unable to get Local App Data Folder: %v", err)
-			return "."
-		}
-		return filepath.Join(localAppDataPath, "Arduino15")
-	default:
-		return "."
-	}
-}

test/test_cache.py

@@ -0,0 +1,41 @@
+# This file is part of arduino-cli.
+#
+# Copyright 2020 ARDUINO SA (http://www.arduino.cc/)
+#
+# This software is released under the GNU General Public License version 3,
+# which covers the main part of arduino-cli.
+# The terms of this license can be found at:
+# https://www.gnu.org/licenses/gpl-3.0.en.html
+#
+# You can be released from the requirements of the above licenses by purchasing
+# a commercial license. Buying such a license is mandatory if you want to modify or
+# otherwise use the software for commercial activities involving the Arduino
+# software without disclosing the source code of your own applications. To purchase
+# a commercial license, send an email to license@arduino.cc.
+import os
+import platform
+
+
+def test_cache_clean(run_command):
+    """
+    Clean the cache under arduino caching file directory which is
+    "<Arduino configure file path>/staging"
+    """
+    result = run_command("cache clean")
+    assert result.ok
+
+    # Generate /staging directory
+    result = run_command("lib list")
+    assert result.ok
+
+    result = run_command("cache clean")
+    assert result.ok
+
+    running_platform = platform.system()
+    homeDir = os.path.expanduser("~")
+    if running_platform == "Linux":
+        assert not (os.path.isdir(homeDir + ".arduino15/staging"))
+    elif running_platform == "Darwin":
+        assert not (os.path.isdir(homeDir + "Library/Arduino15/staging"))
+    elif running_platform == "Windows":
+        assert not (os.path.isdir(homeDir + "Arduino15/staging"))