Cached ports are now reset on discovery stop

silvanocerza · cmaglie · commit cfc7aa4a28f0 · 2021-08-19T18:40:53.000+02:00
diff --git a/arduino/discovery/discovery.go b/arduino/discovery/discovery.go
@@ -342,7 +342,7 @@ func (disc *PluggableDiscovery) Stop() error {
 	}
 	disc.statusMutex.Lock()
 	defer disc.statusMutex.Unlock()
-	// TODO: Should we clear cached ports here?
+	disc.cachedPorts = map[string]*Port{}
 	if disc.eventChan != nil {
 		close(disc.eventChan)
 		disc.eventChan = nil

Original file line number	Diff line number	Diff line change
`@@ -342,7 +342,7 @@ func (disc *PluggableDiscovery) Stop() error {`
`342`	`342`	`}`
`343`	`343`	`disc.statusMutex.Lock()`
`344`	`344`	`defer disc.statusMutex.Unlock()`
`345`		`- // TODO: Should we clear cached ports here?`
	`345`	`+ disc.cachedPorts = map[string]*Port{}`
`346`	`346`	`if disc.eventChan != nil {`
`347`	`347`	`close(disc.eventChan)`
`348`	`348`	`disc.eventChan = nil`