Fixed nasty regression in properties map creation

cmaglie · cmaglie · commit 5fc6787168de · 2018-10-08T19:54:05.000+02:00
Fix #62
diff --git a/arduino/cores/status.go b/arduino/cores/status.go
@@ -58,7 +58,6 @@ func (packages *Packages) GetOrCreatePackage(packager string) *Package {
 		Platforms: map[string]*Platform{},
 		Tools:     map[string]*Tool{},
 		Packages:  packages,
-		//Properties: properties.Map{},
 	}
 	packages.Packages[packager] = targetPackage
 	return targetPackage
diff --git a/commands/upload/upload.go b/commands/upload/upload.go
@@ -158,7 +158,7 @@ func run(command *cobra.Command, args []string) {
 	}
 
 	// Build configuration for upload
-	uploadProperties := properties.Map{}
+	uploadProperties := properties.NewMap()
 	if referencedPlatformRelease != nil {
 		uploadProperties.Merge(referencedPlatformRelease.Properties)
 	}

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,6 @@ func (packages Packages) GetOrCreatePackage(packager string) Package {`
`58`	`58`	`Platforms: map[string]*Platform{},`
`59`	`59`	`Tools: map[string]*Tool{},`
`60`	`60`	`Packages: packages,`
`61`		`- //Properties: properties.Map{},`
`62`	`61`	`}`
`63`	`62`	`packages.Packages[packager] = targetPackage`
`64`	`63`	`return targetPackage`
Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ func run(command *cobra.Command, args []string) {`
`158`	`158`	`}`
`159`	`159`
`160`	`160`	`// Build configuration for upload`
`161`		`- uploadProperties := properties.Map{}`
	`161`	`+ uploadProperties := properties.NewMap()`
`162`	`162`	`if referencedPlatformRelease != nil {`
`163`	`163`	`uploadProperties.Merge(referencedPlatformRelease.Properties)`
`164`	`164`	`}`