Skip to content

Commit 4ae6a6d

Browse files
cmagliecmaglie
committed
Removed ambigous "Identification properties" from board details
It's the last piece of the fqbn (like the "uno" in "arduino:avr:uno"). We use it internally but there is no point in showing it in the board details command since there is already the FQBN.
1 parent b627189 commit 4ae6a6d

File tree

3 files changed

+25
-27
lines changed

3 files changed

+25
-27
lines changed

‎cli/board/details.go‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ func (dr detailsResult) String() string {
9797
t.SetColumnWidthMode(1, table.Average)
9898
t.AddRow(tr("Board name:"), details.Name)
9999
t.AddRow("FQBN:", details.Fqbn)
100-
t.AddRow(tr("Identification properties:"), details.PropertiesId)
101100
t.AddRow(tr("Board version:"), details.Version)
102101

103102
if details.Official {

‎i18n/data/en.po‎

Lines changed: 21 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ msgstr "Available Commands:"
1717
msgid "Board name:"
1818
msgstr "Board name:"
1919

20-
#: cli/board/details.go:101
20+
#: cli/board/details.go:100
2121
msgid "Board version:"
2222
msgstr "Board version:"
2323

24-
#: cli/board/details.go:142
24+
#: cli/board/details.go:141
2525
msgid "Checksum:"
2626
msgstr "Checksum:"
2727

@@ -34,7 +34,7 @@ msgstr "Error getting board details: %v"
3434
msgid "Examples:"
3535
msgstr "Examples:"
3636

37-
#: cli/board/details.go:140
37+
#: cli/board/details.go:139
3838
msgid "File:"
3939
msgstr "File:"
4040

@@ -46,76 +46,75 @@ msgstr "Flags:"
4646
msgid "Global Flags:"
4747
msgstr "Global Flags:"
4848

49-
#: cli/board/details.go:100
50-
#: cli/board/details.go:112
49+
#: cli/board/details.go:111
5150
msgid "Identification properties:"
5251
msgstr "Identification properties:"
5352

54-
#: cli/board/details.go:139
53+
#: cli/board/details.go:138
5554
msgid "OS:"
5655
msgstr "OS:"
5756

58-
#: cli/board/details.go:105
57+
#: cli/board/details.go:104
5958
msgid "Official Arduino board:"
6059
msgstr "Official Arduino board:"
6160

62-
#: cli/board/details.go:151
61+
#: cli/board/details.go:150
6362
msgid "Option:"
6463
msgstr "Option:"
6564

66-
#: cli/board/details.go:121
65+
#: cli/board/details.go:120
6766
msgid "Package URL:"
6867
msgstr "Package URL:"
6968

70-
#: cli/board/details.go:120
69+
#: cli/board/details.go:119
7170
msgid "Package maintainer:"
7271
msgstr "Package maintainer:"
7372

74-
#: cli/board/details.go:119
73+
#: cli/board/details.go:118
7574
msgid "Package name:"
7675
msgstr "Package name:"
7776

78-
#: cli/board/details.go:123
77+
#: cli/board/details.go:122
7978
msgid "Package online help:"
8079
msgstr "Package online help:"
8180

82-
#: cli/board/details.go:122
81+
#: cli/board/details.go:121
8382
msgid "Package website:"
8483
msgstr "Package website:"
8584

86-
#: cli/board/details.go:129
85+
#: cli/board/details.go:128
8786
msgid "Platform URL:"
8887
msgstr "Platform URL:"
8988

90-
#: cli/board/details.go:128
89+
#: cli/board/details.go:127
9190
msgid "Platform architecture:"
9291
msgstr "Platform architecture:"
9392

94-
#: cli/board/details.go:127
93+
#: cli/board/details.go:126
9594
msgid "Platform category:"
9695
msgstr "Platform category:"
9796

98-
#: cli/board/details.go:132
97+
#: cli/board/details.go:131
9998
msgid "Platform checksum:"
10099
msgstr "Platform checksum:"
101100

102-
#: cli/board/details.go:130
101+
#: cli/board/details.go:129
103102
msgid "Platform file name:"
104103
msgstr "Platform file name:"
105104

106-
#: cli/board/details.go:126
105+
#: cli/board/details.go:125
107106
msgid "Platform name:"
108107
msgstr "Platform name:"
109108

110-
#: cli/board/details.go:131
109+
#: cli/board/details.go:130
111110
msgid "Platform size (bytes):"
112111
msgstr "Platform size (bytes):"
113112

114113
#: cli/board/details.go:40
115114
msgid "Print details about a board."
116115
msgstr "Print details about a board."
117116

118-
#: cli/board/details.go:136
117+
#: cli/board/details.go:135
119118
msgid "Required tools:"
120119
msgstr "Required tools:"
121120

@@ -127,7 +126,7 @@ msgstr "Show full board details"
127126
msgid "Show information about a board, in particular if the board has options to be specified in the FQBN."
128127
msgstr "Show information about a board, in particular if the board has options to be specified in the FQBN."
129128

130-
#: cli/board/details.go:141
129+
#: cli/board/details.go:140
131130
msgid "Size (bytes):"
132131
msgstr "Size (bytes):"
133132

‎i18n/rice-box.go‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ func init() {
1717
}
1818
file3 := &embedded.EmbeddedFile{
1919
Filename: "en.po",
20-
FileModTime: time.Unix(1592475372, 0),
20+
FileModTime: time.Unix(1592476050, 0),
2121

22-
Content: string("msgid \"\"\nmsgstr \"\"\n\n#: cli/usage.go:31\nmsgid \"Additional help topics:\"\nmsgstr \"Additional help topics:\"\n\n#: cli/usage.go:26\nmsgid \"Aliases:\"\nmsgstr \"Aliases:\"\n\n#: cli/usage.go:28\nmsgid \"Available Commands:\"\nmsgstr \"Available Commands:\"\n\n#: cli/board/details.go:98\nmsgid \"Board name:\"\nmsgstr \"Board name:\"\n\n#: cli/board/details.go:101\nmsgid \"Board version:\"\nmsgstr \"Board version:\"\n\n#: cli/board/details.go:142\nmsgid \"Checksum:\"\nmsgstr \"Checksum:\"\n\n#: cli/board/details.go:55\n#: cli/board/details.go:65\nmsgid \"Error getting board details: %v\"\nmsgstr \"Error getting board details: %v\"\n\n#: cli/usage.go:27\nmsgid \"Examples:\"\nmsgstr \"Examples:\"\n\n#: cli/board/details.go:140\nmsgid \"File:\"\nmsgstr \"File:\"\n\n#: cli/usage.go:29\nmsgid \"Flags:\"\nmsgstr \"Flags:\"\n\n#: cli/usage.go:30\nmsgid \"Global Flags:\"\nmsgstr \"Global Flags:\"\n\n#: cli/board/details.go:100\n#: cli/board/details.go:112\nmsgid \"Identification properties:\"\nmsgstr \"Identification properties:\"\n\n#: cli/board/details.go:139\nmsgid \"OS:\"\nmsgstr \"OS:\"\n\n#: cli/board/details.go:105\nmsgid \"Official Arduino board:\"\nmsgstr \"Official Arduino board:\"\n\n#: cli/board/details.go:151\nmsgid \"Option:\"\nmsgstr \"Option:\"\n\n#: cli/board/details.go:121\nmsgid \"Package URL:\"\nmsgstr \"Package URL:\"\n\n#: cli/board/details.go:120\nmsgid \"Package maintainer:\"\nmsgstr \"Package maintainer:\"\n\n#: cli/board/details.go:119\nmsgid \"Package name:\"\nmsgstr \"Package name:\"\n\n#: cli/board/details.go:123\nmsgid \"Package online help:\"\nmsgstr \"Package online help:\"\n\n#: cli/board/details.go:122\nmsgid \"Package website:\"\nmsgstr \"Package website:\"\n\n#: cli/board/details.go:129\nmsgid \"Platform URL:\"\nmsgstr \"Platform URL:\"\n\n#: cli/board/details.go:128\nmsgid \"Platform architecture:\"\nmsgstr \"Platform architecture:\"\n\n#: cli/board/details.go:127\nmsgid \"Platform category:\"\nmsgstr \"Platform category:\"\n\n#: cli/board/details.go:132\nmsgid \"Platform checksum:\"\nmsgstr \"Platform checksum:\"\n\n#: cli/board/details.go:130\nmsgid \"Platform file name:\"\nmsgstr \"Platform file name:\"\n\n#: cli/board/details.go:126\nmsgid \"Platform name:\"\nmsgstr \"Platform name:\"\n\n#: cli/board/details.go:131\nmsgid \"Platform size (bytes):\"\nmsgstr \"Platform size (bytes):\"\n\n#: cli/board/details.go:40\nmsgid \"Print details about a board.\"\nmsgstr \"Print details about a board.\"\n\n#: cli/board/details.go:136\nmsgid \"Required tools:\"\nmsgstr \"Required tools:\"\n\n#: cli/board/details.go:47\nmsgid \"Show full board details\"\nmsgstr \"Show full board details\"\n\n#: cli/board/details.go:41\nmsgid \"Show information about a board, in particular if the board has options to be specified in the FQBN.\"\nmsgstr \"Show information about a board, in particular if the board has options to be specified in the FQBN.\"\n\n#: cli/board/details.go:141\nmsgid \"Size (bytes):\"\nmsgstr \"Size (bytes):\"\n\n#: cli/usage.go:25\nmsgid \"Usage:\"\nmsgstr \"Usage:\"\n\n#: cli/usage.go:32\nmsgid \"Use %s for more information about a command.\"\nmsgstr \"Use %s for more information about a command.\"\n\n"),
22+
Content: string("msgid \"\"\nmsgstr \"\"\n\n#: cli/usage.go:31\nmsgid \"Additional help topics:\"\nmsgstr \"Additional help topics:\"\n\n#: cli/usage.go:26\nmsgid \"Aliases:\"\nmsgstr \"Aliases:\"\n\n#: cli/usage.go:28\nmsgid \"Available Commands:\"\nmsgstr \"Available Commands:\"\n\n#: cli/board/details.go:98\nmsgid \"Board name:\"\nmsgstr \"Board name:\"\n\n#: cli/board/details.go:100\nmsgid \"Board version:\"\nmsgstr \"Board version:\"\n\n#: cli/board/details.go:141\nmsgid \"Checksum:\"\nmsgstr \"Checksum:\"\n\n#: cli/board/details.go:55\n#: cli/board/details.go:65\nmsgid \"Error getting board details: %v\"\nmsgstr \"Error getting board details: %v\"\n\n#: cli/usage.go:27\nmsgid \"Examples:\"\nmsgstr \"Examples:\"\n\n#: cli/board/details.go:139\nmsgid \"File:\"\nmsgstr \"File:\"\n\n#: cli/usage.go:29\nmsgid \"Flags:\"\nmsgstr \"Flags:\"\n\n#: cli/usage.go:30\nmsgid \"Global Flags:\"\nmsgstr \"Global Flags:\"\n\n#: cli/board/details.go:111\nmsgid \"Identification properties:\"\nmsgstr \"Identification properties:\"\n\n#: cli/board/details.go:138\nmsgid \"OS:\"\nmsgstr \"OS:\"\n\n#: cli/board/details.go:104\nmsgid \"Official Arduino board:\"\nmsgstr \"Official Arduino board:\"\n\n#: cli/board/details.go:150\nmsgid \"Option:\"\nmsgstr \"Option:\"\n\n#: cli/board/details.go:120\nmsgid \"Package URL:\"\nmsgstr \"Package URL:\"\n\n#: cli/board/details.go:119\nmsgid \"Package maintainer:\"\nmsgstr \"Package maintainer:\"\n\n#: cli/board/details.go:118\nmsgid \"Package name:\"\nmsgstr \"Package name:\"\n\n#: cli/board/details.go:122\nmsgid \"Package online help:\"\nmsgstr \"Package online help:\"\n\n#: cli/board/details.go:121\nmsgid \"Package website:\"\nmsgstr \"Package website:\"\n\n#: cli/board/details.go:128\nmsgid \"Platform URL:\"\nmsgstr \"Platform URL:\"\n\n#: cli/board/details.go:127\nmsgid \"Platform architecture:\"\nmsgstr \"Platform architecture:\"\n\n#: cli/board/details.go:126\nmsgid \"Platform category:\"\nmsgstr \"Platform category:\"\n\n#: cli/board/details.go:131\nmsgid \"Platform checksum:\"\nmsgstr \"Platform checksum:\"\n\n#: cli/board/details.go:129\nmsgid \"Platform file name:\"\nmsgstr \"Platform file name:\"\n\n#: cli/board/details.go:125\nmsgid \"Platform name:\"\nmsgstr \"Platform name:\"\n\n#: cli/board/details.go:130\nmsgid \"Platform size (bytes):\"\nmsgstr \"Platform size (bytes):\"\n\n#: cli/board/details.go:40\nmsgid \"Print details about a board.\"\nmsgstr \"Print details about a board.\"\n\n#: cli/board/details.go:135\nmsgid \"Required tools:\"\nmsgstr \"Required tools:\"\n\n#: cli/board/details.go:47\nmsgid \"Show full board details\"\nmsgstr \"Show full board details\"\n\n#: cli/board/details.go:41\nmsgid \"Show information about a board, in particular if the board has options to be specified in the FQBN.\"\nmsgstr \"Show information about a board, in particular if the board has options to be specified in the FQBN.\"\n\n#: cli/board/details.go:140\nmsgid \"Size (bytes):\"\nmsgstr \"Size (bytes):\"\n\n#: cli/usage.go:25\nmsgid \"Usage:\"\nmsgstr \"Usage:\"\n\n#: cli/usage.go:32\nmsgid \"Use %s for more information about a command.\"\nmsgstr \"Use %s for more information about a command.\"\n\n"),
2323
}
2424
file4 := &embedded.EmbeddedFile{
2525
Filename: "it_IT.po",
@@ -37,7 +37,7 @@ func init() {
3737
// define dirs
3838
dir1 := &embedded.EmbeddedDir{
3939
Filename: "",
40-
DirModTime: time.Unix(1592475354, 0),
40+
DirModTime: time.Unix(1592476041, 0),
4141
ChildFiles: []*embedded.EmbeddedFile{
4242
file2, // ".gitkeep"
4343
file3, // "en.po"
@@ -53,7 +53,7 @@ func init() {
5353
// register embeddedBox
5454
embedded.RegisterEmbeddedBox(`./data`, &embedded.EmbeddedBox{
5555
Name: `./data`,
56-
Time: time.Unix(1592475354, 0),
56+
Time: time.Unix(1592476041, 0),
5757
Dirs: map[string]*embedded.EmbeddedDir{
5858
"": dir1,
5959
},

0 commit comments

Comments
 (0)