Fix crash when attempting upload without specifying port address

silvanocerza · silvanocerza · commit 46e58b560029 · 2021-07-23T14:38:09.000+02:00
diff --git a/cli/arguments/port.go b/cli/arguments/port.go
@@ -61,7 +61,14 @@ func (p *Port) GetPort(instance *rpc.Instance, sk *sketch.Sketch) (*discovery.Po
 		}
 	}
 	if address == "" {
-		return nil, nil
+		// If no address is provided we assume the user is trying to upload
+		// to a board that supports a tool that automatically detects
+		// the attached board without specifying explictly a port.
+		// Tools that work this way must be specified using the property
+		// "BOARD_ID.upload.tool.default" in the platform's boards.txt.
+		return &discovery.Port{
+			Protocol: "default",
+		}, nil
 	}
 	logrus.WithField("port", address).Tracef("Upload port")
 

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,14 @@ func (p Port) GetPort(instance rpc.Instance, sk sketch.Sketch) (discovery.Po`
`61`	`61`	`}`
`62`	`62`	`}`
`63`	`63`	`if address == "" {`
`64`		`- return nil, nil`
	`64`	`+ // If no address is provided we assume the user is trying to upload`
	`65`	`+ // to a board that supports a tool that automatically detects`
	`66`	`+ // the attached board without specifying explictly a port.`
	`67`	`+ // Tools that work this way must be specified using the property`
	`68`	`+ // "BOARD_ID.upload.tool.default" in the platform's boards.txt.`
	`69`	`+ return &discovery.Port{`
	`70`	`+ Protocol: "default",`
	`71`	`+ }, nil`
`65`	`72`	`}`
`66`	`73`	`logrus.WithField("port", address).Tracef("Upload port")`
`67`	`74`