Clone list before changing it by append

cmaglie · cmaglie · commit 13a7b1b93318 · 2025-08-25T16:06:48.000+02:00
diff --git a/internal/arduino/builder/internal/detector/detector.go b/internal/arduino/builder/internal/detector/detector.go
@@ -355,7 +355,7 @@ func (l *SketchLibrariesDetector) gccPreprocessTask(sourceFile *sourceFile, buil
 	// search path, but only for the source code of the library, so we temporary
 	// copy the current search path list and add the library' utility directory
 	// if needed.
-	includeFolders := l.includeFolders
+	includeFolders := l.includeFolders.Clone()
 	if extraInclude := sourceFile.ExtraIncludePath; extraInclude != nil {
 		includeFolders = append(includeFolders, extraInclude)
 	}

Original file line number	Diff line number	Diff line change
`@@ -355,7 +355,7 @@ func (l SketchLibrariesDetector) gccPreprocessTask(sourceFile sourceFile, buil`
`355`	`355`	`// search path, but only for the source code of the library, so we temporary`
`356`	`356`	`// copy the current search path list and add the library' utility directory`
`357`	`357`	`// if needed.`
`358`		`- includeFolders := l.includeFolders`
	`358`	`+ includeFolders := l.includeFolders.Clone()`
`359`	`359`	`if extraInclude := sourceFile.ExtraIncludePath; extraInclude != nil {`
`360`	`360`	`includeFolders = append(includeFolders, extraInclude)`
`361`	`361`	`}`