The board loader now detects default arguments in FQBN "config"

This commit fixes the tests

Author: cmaglie

test/add_build_board_property_if_missing_test.go

@@ -34,7 +34,6 @@ import (
 	"testing"
 
 	"github.com/arduino/arduino-builder"
-	"github.com/arduino/arduino-builder/constants"
 	"github.com/arduino/arduino-builder/types"
 	"github.com/arduino/arduino-cli/arduino/cores"
 	"github.com/arduino/go-paths-helper"
@@ -53,6 +52,7 @@ func TestAddBuildBoardPropertyIfMissing(t *testing.T) {
 	ctx := &types.Context{
 		HardwareDirs: paths.NewPathList(filepath.Join("..", "hardware"), "hardware", "downloaded_hardware", "user_hardware"),
 		FQBN:         parseFQBN(t, "my_avr_platform:avr:mymega"),
+		Verbose:      true,
 	}
 
 	commands := []types.Command{
@@ -74,16 +74,17 @@ func TestAddBuildBoardPropertyIfMissing(t *testing.T) {
 	require.Equal(t, "avr", targetPlatform.Platform.Architecture)
 	targetBoard := ctx.TargetBoard
 	require.Equal(t, "mymega", targetBoard.BoardID)
-	require.Equal(t, "", targetBoard.Properties.Get(constants.BUILD_PROPERTIES_BUILD_MCU))
-	require.Equal(t, "AVR_MYMEGA", targetBoard.Properties.Get(constants.BUILD_PROPERTIES_BUILD_BOARD))
+	require.Equal(t, "atmega2560", targetBoard.Properties.Get("build.mcu"))
+	require.Equal(t, "AVR_MYMEGA2560", targetBoard.Properties.Get("build.board"))
 }
 
 func TestAddBuildBoardPropertyIfMissingNotMissing(t *testing.T) {
 	DownloadCoresAndToolsAndLibraries(t)
 
 	ctx := &types.Context{
 		HardwareDirs: paths.NewPathList(filepath.Join("..", "hardware"), "hardware", "downloaded_hardware", "user_hardware"),
-		FQBN:         parseFQBN(t, "my_avr_platform:avr:mymega:cpu=atmega2560"),
+		FQBN:         parseFQBN(t, "my_avr_platform:avr:mymega:cpu=atmega1280"),
+		Verbose:      true,
 	}
 
 	commands := []types.Command{
@@ -103,6 +104,6 @@ func TestAddBuildBoardPropertyIfMissingNotMissing(t *testing.T) {
 	require.Equal(t, "avr", targetPlatform.Platform.Architecture)
 	targetBoard := ctx.TargetBoard
 	require.Equal(t, "mymega", targetBoard.BoardID)
-	require.Equal(t, "atmega2560", targetBoard.Properties.Get(constants.BUILD_PROPERTIES_BUILD_MCU))
-	require.Equal(t, "AVR_MEGA2560", targetBoard.Properties.Get(constants.BUILD_PROPERTIES_BUILD_BOARD))
+	require.Equal(t, "atmega1280", targetBoard.Properties.Get("build.mcu"))
+	require.Equal(t, "AVR_MYMEGA", targetBoard.Properties.Get("build.board"))
 }

test/user_hardware/my_avr_platform/avr/boards.txt

@@ -68,7 +68,7 @@ mymega.menu.cpu.atmega2560.bootloader.extended_fuses=0xFD
 mymega.menu.cpu.atmega2560.bootloader.file={bootloader._folder}/stk500boot_v2_mega2560.hex
 
 mymega.menu.cpu.atmega2560.build.mcu=atmega2560
-mymega.menu.cpu.atmega2560.build.board=AVR_MEGA2560
+mymega.menu.cpu.atmega2560.build.board=AVR_MYMEGA2560
 
 mymega.menu.cpu.atmega1280=ATmega1280
 
@@ -82,4 +82,4 @@ mymega.menu.cpu.atmega1280.bootloader.extended_fuses=0xF5
 mymega.menu.cpu.atmega1280.bootloader.file={bootloader._folder}/ATmegaBOOT_168_atmega1280.hex
 
 mymega.menu.cpu.atmega1280.build.mcu=atmega1280
-mymega.menu.cpu.atmega1280.build.board=AVR_MEGA
+mymega.menu.cpu.atmega1280.build.board=AVR_MYMEGA