Added Ethernet library in the test-suite

A test sketch that is supposed to fail has been slightly modified
to include a non existing fake library (the old sketch included
Ethernet that is now available)

Signed-off-by: Cristian Maglie <c.maglie@arduino.cc>

Author: cmaglie

src/arduino.cc/builder/test/downloaded_libraries/.gitignore

@@ -1,6 +1 @@
-A*
-B*
-C*
-H*
-P*
-R*
+*

src/arduino.cc/builder/test/helper_tools_downloader.go

@@ -134,6 +134,7 @@ func DownloadCoresAndToolsAndLibraries(t *testing.T) {
 		Library{Name: "Adafruit PN532", Version: "1.0.0"},
 		Library{Name: "Bridge", Version: "1.1.0"},
 		Library{Name: "CapacitiveSensor", Version: "0.5.0", VersionInLibProperties: "0.5"},
+		Library{Name: "Ethernet", Version: "1.1.1"},
 		Library{Name: "Robot IR Remote", Version: "1.0.2"},
 	}
 

src/arduino.cc/builder/test/includes_finder_with_gcc_test.go

@@ -209,7 +209,7 @@ func TestIncludesFinderWithGCCSketchWithThatChecksIfSPIHasTransactions(t *testin
 	require.Equal(t, "SPI", importedLibraries[0].Name)
 }
 
-func TestIncludesFinderWithGCCSketchWithThatChecksIfSPIHasTransactionsAndIncludesMissingEthernet(t *testing.T) {
+func TestIncludesFinderWithGCCSketchWithThatChecksIfSPIHasTransactionsAndIncludesMissingLib(t *testing.T) {
 	DownloadCoresAndToolsAndLibraries(t)
 
 	context := make(map[string]interface{})
@@ -247,7 +247,7 @@ func TestIncludesFinderWithGCCSketchWithThatChecksIfSPIHasTransactionsAndInclude
 	includes := context[constants.CTX_INCLUDES].([]string)
 	require.Equal(t, 2, len(includes))
 	sort.Strings(includes)
-	require.Equal(t, "Ethernet.h", includes[0])
+	require.Equal(t, "Inexistent.h", includes[0])
 	require.Equal(t, "SPI.h", includes[1])
 
 	importedLibraries := context[constants.CTX_IMPORTED_LIBRARIES].([]*types.Library)

src/arduino.cc/builder/test/libraries_loader_test.go

@@ -69,7 +69,7 @@ func TestLoadLibrariesAVR(t *testing.T) {
 	require.Equal(t, Abs(t, filepath.Join("libraries")), librariesFolders[2])
 
 	libraries := context[constants.CTX_LIBRARIES].([]*types.Library)
-	require.Equal(t, 18, len(libraries))
+	require.Equal(t, 19, len(libraries))
 
 	sort.Sort(ByLibraryName(libraries))
 
@@ -107,6 +107,8 @@ func TestLoadLibrariesAVR(t *testing.T) {
 	idx++
 	require.Equal(t, "EEPROM", libraries[idx].Name)
 	idx++
+	require.Equal(t, "Ethernet", libraries[idx].Name)
+	idx++
 	require.Equal(t, "FakeAudio", libraries[idx].Name)
 	idx++
 	require.Equal(t, "HID", libraries[idx].Name)
@@ -175,7 +177,7 @@ func TestLoadLibrariesSAM(t *testing.T) {
 	require.Equal(t, Abs(t, filepath.Join("libraries")), librariesFolders[2])
 
 	libraries := context[constants.CTX_LIBRARIES].([]*types.Library)
-	require.Equal(t, 16, len(libraries))
+	require.Equal(t, 17, len(libraries))
 
 	sort.Sort(ByLibraryName(libraries))
 
@@ -192,6 +194,8 @@ func TestLoadLibrariesSAM(t *testing.T) {
 	idx++
 	require.Equal(t, "CapacitiveSensor", libraries[idx].Name)
 	idx++
+	require.Equal(t, "Ethernet", libraries[idx].Name)
+	idx++
 	require.Equal(t, "FakeAudio", libraries[idx].Name)
 	idx++
 	require.Equal(t, "HID", libraries[idx].Name)

src/arduino.cc/builder/test/sketch_that_checks_if_SPI_has_transactions_and_includes_missing_Ethernet/sketch.ino

@@ -1,5 +1,5 @@
 #include <SPI.h>
-#include <Ethernet.h>
+#include <Inexistent.h>
 
 #if !defined(SPI_HAS_TRANSACTION) || !SPI_HAS_TRANSACTION
 #error "Where is my SPI_HAS_TRANSACTION!?!?"