Mute log output during autocomplete via rpc

Should solve arduino/Arduino#6818

Author: facchinm

src/arduino.cc/builder/grpc/rpc.go

@@ -9,6 +9,7 @@ import (
 	"strings"
 
 	"arduino.cc/builder"
+	"arduino.cc/builder/i18n"
 	"arduino.cc/builder/types"
 	"arduino.cc/builder/utils"
 	"github.com/fsnotify/fsnotify"
@@ -87,6 +88,7 @@ func (s *builderServer) Autocomplete(ctx context.Context, args *pb.BuildParams)
 	s.ctx.WarningsLevel = args.WarningsLevel
 	s.ctx.PrototypesSection = ""
 	s.ctx.CodeCompleteAt = args.CodeCompleteAt
+	s.ctx.CodeCompletions = ""
 
 	s.ctx.IncludeFolders = s.ctx.IncludeFolders[0:0]
 	s.ctx.LibrariesObjectFiles = s.ctx.LibrariesObjectFiles[0:0]
@@ -96,14 +98,16 @@ func (s *builderServer) Autocomplete(ctx context.Context, args *pb.BuildParams)
 	s.ctx.ImportedLibraries = s.ctx.ImportedLibraries[0:0]
 
 	s.watch()
+	oldlogger := s.ctx.GetLogger()
+	logger := i18n.NoopLogger{}
+	s.ctx.SetLogger(logger)
 
 	err := builder.RunPreprocess(s.ctx)
-	if err != nil {
-		return &pb.Response{Line: s.ctx.GetLogger().Flush()}, err
-	}
 
-	// No feature was found, return an unnamed feature
-	return &pb.Response{Line: s.ctx.GetLogger().Flush()}, nil
+	response := pb.Response{Line: s.ctx.CodeCompletions}
+	s.ctx.SetLogger(oldlogger)
+
+	return &response, err
 }
 
 // GetFeature returns the feature at the given point.

src/arduino.cc/builder/preprocess_sketch.go

@@ -127,6 +127,10 @@ func (s *ArduinoPreprocessorRunner) Run(ctx *types.Context) error {
 type OutputCodeCompletions struct{}
 
 func (s *OutputCodeCompletions) Run(ctx *types.Context) error {
-	ctx.GetLogger().Println(constants.LOG_LEVEL_INFO, "%s", ctx.CodeCompletions)
+	if ctx.CodeCompletions == "" {
+		// we assume it is a json, let's make it compliant at least
+		ctx.CodeCompletions = "[]"
+	}
+	ctx.GetLogger().Println(constants.LOG_LEVEL_INFO, ctx.CodeCompletions)
 	return nil
 }