-
Notifications
You must be signed in to change notification settings - Fork 4
fix(api): allow missing required variable when a brick is added #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dido18
wants to merge
8
commits into
main
Choose a base branch
from
fix-add-brick
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+161
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate test data feat: add AppFromExample configuration and Python main file for testing
… update test cases
Contributor
Author
|
Test: create an app from scratch
# app.yaml: The main configuration file for your Arduino App.
# This file describes the application's metadata and properties.
# The user-visible name of the application.
name: from scratch
# A brief description of what the application does.
description: ""
# The icon for the application can be an emoji or a short string.
icon: 😀
# A list of network ports that the application exposes.
# Example: [80, 443]
ports: []
# A list of bricks used by this application.
bricks: []
name: from scratch
description: ""
ports: []
bricks:
- arduino:arduino_cloud: {}
icon: 😀
name: from scratch
description: ""
ports: []
bricks:
- arduino:arduino_cloud:
variables:
ARDUINO_DEVICE_ID: a
ARDUINO_SECRET: b
icon: 😀
|
…Create and update test case descriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close #68
When a brick with required variables is added to an app created from scratch the operation fails.
This is because the FE (appLab) does not pass the required variables when the
PUT /v1/apps/{appID}/bricks/{brickID}is called.If the request body does not contain a value for a required variable, the operation fails.
Additionally, the issue is not present when an app is cloned.
This is because a cloned app already has the
arduino:arduino_cloudbrick configured in theapp.yaml. In this scenario, the FE manages the required variables correctly by asking the users to fill in the required variables.Change description
Do not fail with an error, but log a Warning and put the required variable as an empty string
Additional Notes
Reviewer checklist
main.