feat: implement app cache deletion #59
Conversation
alessio-perugini
force-pushed
the
main
branch
from
bef313a to
d95e8dc
Compare
Introduce a `cache clean <app-id>` command to clean app cache. This implementation also tries to stop the related app if running. In case we do not care about that we can simply rm -rf `.cache/*`. Closes arduino#52
alessio-perugini
force-pushed
the
main
branch
from
d95e8dc to
4f25421
Compare
I think stopping the running app makes sense; otherwise, we could lose the ability to do that afterward. A potential alternative could be to refuse to remove the cache of a running app.
|
|
I also not sure if the command should be in the |
|
I agree with @lucarin91 about the usage of the flag. |
|
I vote for the |
|
While implementing the CLI subcommands I took inspiration from the arduino-cli. My idea was to have similar mapping to what our user based is used to. However I also feel like that the
@lucarin91 yeah I like that |
Add `--force` flag to forcefully terminate the app in case it's running, and then clean the related cache.
|
I'll wait for you guys design decision about the CLI api, in the meantime I've pushed the proposal to introduce the As soon as you reach an agreement shoot me a comment and I'll apply the proposed changes, if any. 🤓 |
|
@alessio-perugini Thinking about it again, |
| if len(args) == 0 { | ||
| return cmd.Help() | ||
| } |
There was a problem hiding this comment.
AFAIK, this should be done automatically by cobra
| if len(args) == 0 { | |
| return cmd.Help() | |
| } |
| func newCacheCleanCmd(cfg config.Configuration) *cobra.Command { | ||
| var forceClean bool | ||
| appCmd := &cobra.Command{ | ||
| Use: "clean-cache", |
There was a problem hiding this comment.
| Use: "clean-cache", | |
| Use: "clean-cache <app-id>", |
| if runningApp.FullPath.EqualsTo(app.FullPath) { | ||
| return ErrCleanCacheRunningApp | ||
| } | ||
|
|
||
| if req.ForceClean && app.AppComposeFilePath().Exist() { | ||
| // We try to remove docker related resources at best effort | ||
| _ = StopAndDestroyApp(ctx, app) | ||
| } |
There was a problem hiding this comment.
You weren't handling the force flag correctly. I think this should work
| if runningApp.FullPath.EqualsTo(app.FullPath) { | |
| return ErrCleanCacheRunningApp | |
| } | |
| if req.ForceClean && app.AppComposeFilePath().Exist() { | |
| // We try to remove docker related resources at best effort | |
| _ = StopAndDestroyApp(ctx, app) | |
| } | |
| if runningApp.FullPath.EqualsTo(app.FullPath) { | |
| if req.ForceClean { | |
| // We try to remove docker related resources at best effort | |
| _ = StopAndDestroyApp(ctx, app) | |
| }else{ | |
| return ErrCleanCacheRunningApp | |
| } | |
| } |
5 participants
Introduce a
cache clean <app-id>command to clean app cache. This implementation also tries to stop the related app if running. In case we do not care about that we can simply rm -rf.cache/*.Super simple implementation. The stopping of an app could be opionionated, eager to see what you think. In case it's too much we can remove that logic and/or trigger it with a specific flag.
Closes #52