fix after code review

Author: lucarin91

internal/api/handlers/update.go

@@ -43,7 +43,7 @@ func HandleCheckUpgradable(updater *update.Manager) http.HandlerFunc {
 		pkgs, err := updater.ListUpgradablePackages(r.Context(), filterFunc)
 		if err != nil {
 			code := update.GetUpdateErrorCode(err)
-			if code == update.OperationInProgress {
+			if code == update.OperationInProgressCode {
 				render.EncodeResponse(w, http.StatusConflict, models.ErrorResponse{
 					Code:    string(code),
 					Details: err.Error(),
@@ -85,7 +85,7 @@ func HandleUpdateApply(updater *update.Manager) http.HandlerFunc {
 		pkgs, err := updater.ListUpgradablePackages(r.Context(), filterFunc)
 		if err != nil {
 			code := update.GetUpdateErrorCode(err)
-			if code == update.OperationInProgress {
+			if code == update.OperationInProgressCode {
 				render.EncodeResponse(w, http.StatusConflict, models.ErrorResponse{
 					Code:    string(code),
 					Details: err.Error(),
@@ -107,7 +107,7 @@ func HandleUpdateApply(updater *update.Manager) http.HandlerFunc {
 		err = updater.UpgradePackages(r.Context(), pkgs)
 		if err != nil {
 			code := update.GetUpdateErrorCode(err)
-			if code == update.OperationInProgress {
+			if code == update.OperationInProgressCode {
 				render.EncodeResponse(w, http.StatusConflict, models.ErrorResponse{
 					Code:    string(code),
 					Details: err.Error(),
@@ -148,7 +148,7 @@ func HandleUpdateEvents(updater *update.Manager) http.HandlerFunc {
 				if event.Type == update.ErrorEvent {
 					err := event.GetError()
 					code := render.InternalServiceErr
-					if c := update.GetUpdateErrorCode(err); c != update.UnknownError {
+					if c := update.GetUpdateErrorCode(err); c != update.UnknownErrorCode {
 						code = render.SSEErrCode(string(c))
 					}
 					sseStream.SendError(render.SSEErrorData{

internal/update/errors.go

@@ -13,11 +13,11 @@ const (
 
 var (
 	ErrOperationAlreadyInProgress = &UpdateError{
-		Code:    OperationInProgress,
+		Code:    OperationInProgressCode,
 		Details: "an operation is already in progress",
 	}
 	ErrNoInternetConnection = &UpdateError{
-		Code:    NoInternetConnection,
+		Code:    NoInternetConnectionCode,
 		Details: "no internet connection available",
 	}
 )
@@ -51,5 +51,5 @@ func GetUpdateErrorCode(err error) ErrorCode {
 			return updateError.Code
 		}
 	}
-	return UnknownError
+	return UnknownErrorCode
 }

internal/update/errors_test.go

@@ -11,12 +11,12 @@ import (
 func TestUpdateError(t *testing.T) {
 	t.Run("known error", func(t *testing.T) {
 		var err error = &UpdateError{
-			Code:    NoInternetConnection,
+			Code:    NoInternetConnectionCode,
 			Details: "no internet connection available",
 		}
 		assert.Equal(t, "no internet connection available", err.Error())
 		assert.Equal(t, "no internet connection available", fmt.Sprintf("%s", err))
-		assert.Equal(t, NoInternetConnection, GetUpdateErrorCode(err))
+		assert.Equal(t, NoInternetConnectionCode, GetUpdateErrorCode(err))
 	})
 
 	t.Run("unknown error", func(t *testing.T) {
@@ -27,6 +27,6 @@ func TestUpdateError(t *testing.T) {
 		assert.Equal(t, "underlying error", fmt.Sprintf("%s", updateErr))
 		assert.Equal(t, underlyingErr, errors.Unwrap(updateErr))
 		assert.True(t, errors.Is(updateErr, underlyingErr))
-		assert.Equal(t, UnknownError, GetUpdateErrorCode(updateErr))
+		assert.Equal(t, UnknownErrorCode, GetUpdateErrorCode(updateErr))
 	})
 }