arduino-app-cli: add app ID completion Add completion for app ID, expressed in human readable form (#478)

Author: alessio-perugini

cmd/arduino-app-cli/app.go

@@ -79,6 +79,7 @@ func newStartCmd() *cobra.Command {
 			}
 			return startHandler(cmd.Context(), app)
 		},
+		ValidArgsFunction: ApplicationNames(),
 	}
 }
 
@@ -97,6 +98,7 @@ func newStopCmd() *cobra.Command {
 			}
 			return stopHandler(cmd.Context(), app)
 		},
+		ValidArgsFunction: ApplicationNames(),
 	}
 }
 
@@ -119,6 +121,7 @@ func newRestartCmd() *cobra.Command {
 			}
 			return startHandler(cmd.Context(), app)
 		},
+		ValidArgsFunction: ApplicationNames(),
 	}
 	return cmd
 }
@@ -139,6 +142,7 @@ func newLogsCmd() *cobra.Command {
 			}
 			return logsHandler(cmd.Context(), app, &tail)
 		},
+		ValidArgsFunction: ApplicationNames(),
 	}
 	cmd.Flags().Uint64Var(&tail, "tail", 100, "Tail the last N logs")
 	return cmd
@@ -151,6 +155,7 @@ func newMonitorCmd() *cobra.Command {
 		RunE: func(cmd *cobra.Command, args []string) error {
 			panic("not implemented")
 		},
+		ValidArgsFunction: ApplicationNames(),
 	}
 
 }

cmd/arduino-app-cli/completion.go

@@ -5,7 +5,10 @@ import (
 
 	"github.com/spf13/cobra"
 
+	"github.com/bcmi-labs/orchestrator/cmd/arduino-app-cli/internal/servicelocator"
 	"github.com/bcmi-labs/orchestrator/cmd/feedback"
+	"github.com/bcmi-labs/orchestrator/cmd/results"
+	"github.com/bcmi-labs/orchestrator/internal/orchestrator"
 )
 
 func newCompletionCommand() *cobra.Command {
@@ -48,3 +51,25 @@ func newCompletionCommand() *cobra.Command {
 
 	return completionCmd
 }
+
+func ApplicationNames() cobra.CompletionFunc {
+	return func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+		apps, err := orchestrator.ListApps(cmd.Context(),
+			servicelocator.GetDockerClient(),
+			orchestrator.ListAppRequest{
+				ShowExamples:                   true,
+				ShowApps:                       true,
+				IncludeNonStandardLocationApps: true,
+			},
+		)
+		if err != nil {
+			return nil, cobra.ShellCompDirectiveError
+		}
+
+		var res []string
+		for _, a := range apps.Apps {
+			res = append(res, results.IdToAlias(a.ID))
+		}
+		return res, cobra.ShellCompDirectiveNoFileComp
+	}
+}