Enable always pull container by default (#546)

Author: alessio-perugini

cmd/arduino-app-cli/daemon/daemon.go

@@ -21,29 +21,12 @@ import (
 )
 
 func NewDaemonCmd(cfg config.Configuration, version string) *cobra.Command {
-	var autoPull bool
 	daemonCmd := &cobra.Command{
 		Use:   "daemon",
 		Short: "Run an HTTP server to expose arduino-app-cli functionality thorough REST API",
 		Run: func(cmd *cobra.Command, args []string) {
 			daemonPort, _ := cmd.Flags().GetString("port")
 
-			if autoPull {
-				go func() {
-					slog.Info("Auto-pull enabled, starting background process...")
-					err := orchestrator.SystemInit(
-						cmd.Context(),
-						servicelocator.GetUsedPythonImageTag(),
-						servicelocator.GetStaticStore(),
-					)
-					if err != nil {
-						slog.Error("Auto-pull process failed", slog.String("error", err.Error()))
-					} else {
-						slog.Info("Auto-pull process completed.")
-					}
-				}()
-			}
-
 			// start the default app in the background
 			go func() {
 				slog.Info("Starting default app")
@@ -59,15 +42,27 @@ func NewDaemonCmd(cfg config.Configuration, version string) *cobra.Command {
 				)
 				if err != nil {
 					slog.Error("Failed to start default app", slog.String("error", err.Error()))
+				} else {
+					slog.Info("Default app started")
+				}
+
+				slog.Info("Try to pull latest docker images in background...")
+				err = orchestrator.SystemInit(
+					cmd.Context(),
+					servicelocator.GetUsedPythonImageTag(),
+					servicelocator.GetStaticStore(),
+				)
+				if err != nil {
+					slog.Error("Auto-pull process failed", slog.String("error", err.Error()))
+				} else {
+					slog.Info("Auto-pull process completed.")
 				}
-				slog.Info("Default app started")
 			}()
 
 			httpHandler(cmd.Context(), cfg, daemonPort, version)
 		},
 	}
 	daemonCmd.Flags().String("port", "8080", "The TCP port the daemon will listen to")
-	daemonCmd.Flags().BoolVarP(&autoPull, "auto-pull", "p", false, "Enable auto-pull of all app images on startup")
 	return daemonCmd
 }
 

internal/orchestrator/system.go

@@ -1,8 +1,11 @@
 package orchestrator
 
 import (
+	"bytes"
 	"context"
+	"encoding/json"
 	"os"
+	"slices"
 	"strings"
 
 	"github.com/arduino/go-paths-helper"
@@ -16,22 +19,31 @@ import (
 
 // SystemInit pulls necessary Docker images.
 func SystemInit(ctx context.Context, pythonImageTag string, staticStore *store.StaticStore) error {
-	preInstallContainer := []string{
+	containersToPreinstall := []string{
 		"ghcr.io/bcmi-labs/arduino/appslab-python-apps-base:" + pythonImageTag,
 	}
 	additionalContainers, err := parseAllModelsRunnerImageTag(staticStore)
 	if err != nil {
 		return err
 	}
-	preInstallContainer = append(preInstallContainer, additionalContainers...)
+	containersToPreinstall = append(containersToPreinstall, additionalContainers...)
+
+	pulledImages, err := listImagesAlreadyPulled(ctx)
+	if err != nil {
+		return err
+	}
+
+	// Filter out containers alredy pulled
+	containersToPreinstall = slices.DeleteFunc(containersToPreinstall, func(v string) bool {
+		return slices.Contains(pulledImages, v)
+	})
 
 	stdout, _, err := feedback.DirectStreams()
 	if err != nil {
 		feedback.Fatal(err.Error(), feedback.ErrBadArgument)
 		return nil
 	}
-
-	for _, container := range preInstallContainer {
+	for _, container := range containersToPreinstall {
 		cmd, err := paths.NewProcess(nil, "docker", "pull", container)
 		if err != nil {
 			return err
@@ -45,6 +57,45 @@ func SystemInit(ctx context.Context, pythonImageTag string, staticStore *store.S
 	return nil
 }
 
+// listImagesAlreadyPulled
+func listImagesAlreadyPulled(ctx context.Context) ([]string, error) {
+	cmd, err := paths.NewProcess(nil,
+		"docker", "images", "--format", "json",
+		"-f", "reference=ghcr.io/bcmi-labs/arduino/*",
+		"-f", "reference=public.ecr.aws/*",
+	)
+	if err != nil {
+		return nil, err
+	}
+
+	// Capture the output to check if the image exists
+	stdout, _, err := cmd.RunAndCaptureOutput(ctx)
+	if err != nil {
+		return nil, err
+	}
+
+	type dockerImage struct {
+		Repository string `json:"Repository"`
+		Tag        string `json:"Tag"`
+	}
+	var resp dockerImage
+	result := []string{}
+	for img := range bytes.Lines(stdout) {
+		if len(img) == 0 {
+			continue
+		}
+		if err := json.Unmarshal(img, &resp); err != nil {
+			return nil, err
+		}
+		if resp.Tag == "<none>" {
+			continue
+		}
+		result = append(result, resp.Repository+":"+resp.Tag)
+	}
+
+	return result, nil
+}
+
 func parseAllModelsRunnerImageTag(staticStore *store.StaticStore) ([]string, error) {
 	composePath := staticStore.GetComposeFolder()
 	brickNamespace := "arduino"