feat: enhance debug logs

Author: mirkoCrobu

cmd/arduino-app-cli/app/new.go

@@ -2,6 +2,7 @@ package app
 
 import (
 	"context"
+	"fmt"
 
 	"github.com/arduino/go-paths-helper"
 	"github.com/spf13/cobra"
@@ -58,6 +59,7 @@ func createHandler(ctx context.Context, name string, icon string, noPython, noSk
 			return nil
 		}
 
+		feedback.Debug(fmt.Sprintf("Creating app from existing app. new id: %q, name: %q", id, name))
 		resp, err := orchestrator.CloneApp(ctx, orchestrator.CloneAppRequest{
 			Name:   &name,
 			FromID: id,

cmd/arduino-app-cli/app/stop.go

@@ -2,7 +2,6 @@ package app
 
 import (
 	"context"
-	"fmt"
 
 	"github.com/spf13/cobra"
 
@@ -33,25 +32,26 @@ func newStopCmd() *cobra.Command {
 }
 
 func stopHandler(ctx context.Context, app app.ArduinoApp) error {
-	out, _, getResult := feedback.OutputStreams()
 
 	for message := range orchestrator.StopApp(ctx, app) {
 		switch message.GetType() {
 		case orchestrator.ProgressType:
-			fmt.Fprintf(out, "Progress: %.0f%%\n", message.GetProgress().Progress)
+			feedback.Progress(message.GetProgress().Progress)
 		case orchestrator.InfoType:
-			fmt.Fprintln(out, "[INFO]", message.GetData())
+			feedback.Info(message.GetData())
+		case orchestrator.DebugType:
+			feedback.Debug(message.GetData())
+		case orchestrator.WarningType:
+			feedback.Warning(message.GetData())
 		case orchestrator.ErrorType:
 			feedback.Fatal(message.GetError().Error(), feedback.ErrGeneric)
 			return nil
 		}
 	}
-	outputResult := getResult()
 
 	feedback.PrintResult(results.StopAppResult{
 		AppName: app.Name,
 		Status:  "stopped",
-		Output:  outputResult,
 	})
 	return nil
 }

internal/orchestrator/orchestrator.go

@@ -188,7 +188,7 @@ func StartApp(ctx context.Context, docker *dockerClient.Client, provisioner *Pro
 				return
 			}
 		}
-		_ = yield(StreamMessage{Type: ProgressType, progress: &Progress{Name: "", Progress: 100.0}})
+		_ = yield(StreamMessage{Type: ProgressType, progress: &Progress{Name: "", Progress: 1.0}})
 	}
 }
 
@@ -198,7 +198,7 @@ func StopApp(ctx context.Context, app app.ArduinoApp) iter.Seq[StreamMessage] {
 		defer cancel()
 
 		callbackWriter := NewCallbackWriter(func(line string) {
-			if !yield(StreamMessage{data: line}) {
+			if !yield(StreamMessage{Type: DebugType, data: line}) {
 				cancel()
 				return
 			}
@@ -209,35 +209,46 @@ func StopApp(ctx context.Context, app app.ArduinoApp) iter.Seq[StreamMessage] {
 			if micro.OnBoard {
 				// On imola we could just disable the microcontroller
 				if err := micro.Disable(context.Background(), nil); err != nil {
-					yield(StreamMessage{error: err})
+					yield(StreamMessage{Type: ErrorType, error: err})
 					return
 				}
 			}
 		}
 
 		if app.MainPythonFile != nil {
+			if !yield(StreamMessage{Type: InfoType, data: "stopping the app..."}) {
+				cancel()
+				return
+			}
 			provisioningStateDir, err := getProvisioningStateDir(app)
 			if err != nil {
-				yield(StreamMessage{error: err})
+				yield(StreamMessage{Type: ErrorType, error: err})
 				return
 			}
 			mainCompose := provisioningStateDir.Join("app-compose.yaml")
 			// In case the app was never started
 			if mainCompose.Exist() {
-				process, err := paths.NewProcess(nil, "docker", "compose", "-f", mainCompose.String(), "stop", fmt.Sprintf("--timeout=%d", DefaultDockerStopTimeoutSeconds))
+
+				command := []string{"docker", "compose", "-f", mainCompose.String(), "stop", fmt.Sprintf("--timeout=%d", DefaultDockerStopTimeoutSeconds)}
+				if !yield(StreamMessage{Type: DebugType, data: "Executing command: " + strings.Join(command, " ")}) {
+					return
+				}
+				process, err := paths.NewProcess(nil, command...)
 				if err != nil {
-					yield(StreamMessage{error: err})
+					yield(StreamMessage{Type: ErrorType, error: err})
 					return
 				}
 				process.RedirectStderrTo(callbackWriter)
 				process.RedirectStdoutTo(callbackWriter)
 				if err := process.RunWithinContext(ctx); err != nil {
-					yield(StreamMessage{error: err})
+					yield(StreamMessage{Type: ErrorType, error: err})
 					return
 				}
+			} else if !yield(StreamMessage{Type: InfoType, data: "App not running, nothing to stop."}) {
+				return
 			}
 		}
-		_ = yield(StreamMessage{progress: &Progress{Name: "", Progress: 100.0}})
+		_ = yield(StreamMessage{Type: ProgressType, progress: &Progress{Name: "", Progress: 1.0}})
 	}
 }