Skip to content

Commit 502f4d1

Browse files
committed
fix(pkg/board): wait for zombie process in adb
1 parent 62e5944 commit 502f4d1

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

pkg/board/remote/adb/adb.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ func (a *ADBConnection) List(path string) ([]remote.FileInfo, error) {
120120
if err := cmd.Start(); err != nil {
121121
return nil, err
122122
}
123+
defer cmd.Wait()
123124

124125
r := bufio.NewReader(output)
125126
_, err = r.ReadBytes('\n') // Skip the first line
@@ -167,6 +168,7 @@ func (a *ADBConnection) Stats(p string) (remote.FileInfo, error) {
167168
if err := cmd.Start(); err != nil {
168169
return remote.FileInfo{}, err
169170
}
171+
defer cmd.Wait()
170172

171173
r := bufio.NewReader(output)
172174
line, err := r.ReadBytes('\n')

pkg/board/remote/adb/adb_nowindows.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,11 @@ func adbReadFile(a *ADBConnection, path string) (io.ReadCloser, error) {
3737
if err := cmd.Start(); err != nil {
3838
return nil, err
3939
}
40+
defer func() {
41+
go func() {
42+
_ = cmd.Wait()
43+
}()
44+
}()
4045
return output, nil
4146
}
4247

0 commit comments

Comments
 (0)