Skip to content

Commit 32c06ae

Browse files
committed
apply code review suggestions
1 parent 9d7e112 commit 32c06ae

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

internal/monitor/monitor.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,19 +32,19 @@ type MessageReaderWriter interface {
3232
Close() error
3333
}
3434

35-
func NewMonitorHandler(ws MessageReaderWriter) (func(), error) {
35+
func NewMonitorHandler(rw MessageReaderWriter) (func(), error) {
3636
// Connect to monitor
3737
mon, err := net.DialTimeout("tcp", "127.0.0.1:7500", time.Second)
3838
if err != nil {
3939
return nil, err
4040
}
4141

4242
return func() {
43-
monitorStream(mon, ws)
43+
monitorStream(mon, rw)
4444
}, nil
4545
}
4646

47-
func monitorStream(mon net.Conn, ws MessageReaderWriter) {
47+
func monitorStream(mon net.Conn, rw MessageReaderWriter) {
4848
logWebsocketError := func(msg string, err error) {
4949
// Do not log simple close or interruption errors
5050
if websocket.IsUnexpectedCloseError(err, websocket.CloseNormalClosure, websocket.CloseGoingAway, websocket.CloseNoStatusReceived, websocket.CloseAbnormalClosure) {
@@ -62,10 +62,10 @@ func monitorStream(mon net.Conn, ws MessageReaderWriter) {
6262
}
6363
go func() {
6464
defer mon.Close()
65-
defer ws.Close()
65+
defer rw.Close()
6666
for {
6767
// Read from websocket and write to monitor
68-
_, msg, err := ws.ReadMessage()
68+
_, msg, err := rw.ReadMessage()
6969
if err != nil {
7070
logWebsocketError("Error reading from websocket", err)
7171
return
@@ -78,7 +78,7 @@ func monitorStream(mon net.Conn, ws MessageReaderWriter) {
7878
}()
7979
go func() {
8080
defer mon.Close()
81-
defer ws.Close()
81+
defer rw.Close()
8282
buff := [1024]byte{}
8383
for {
8484
// Read from monitor and write to websocket
@@ -88,7 +88,7 @@ func monitorStream(mon net.Conn, ws MessageReaderWriter) {
8888
return
8989
}
9090

91-
if err := ws.WriteMessage(websocket.BinaryMessage, buff[:n]); err != nil {
91+
if err := rw.WriteMessage(websocket.BinaryMessage, buff[:n]); err != nil {
9292
logWebsocketError("Error writing to websocket", err)
9393
return
9494
}

0 commit comments

Comments
 (0)