Skip to content

Commit 05abb6a

Browse files
authored
nit pick: set log level (#449)
1 parent 27e577d commit 05abb6a

File tree

1 file changed

+17
-6
lines changed

1 file changed

+17
-6
lines changed

cmd/arduino-app-cli/main.go

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,13 @@ import (
2828
var Version string = "0.0.0-dev"
2929
var format string
3030

31-
func main() {
31+
func run() error {
3232
defer func() { _ = servicelocator.CloseDockerClient() }()
3333

34-
logLevel := ParseLogLevel(cmp.Or(os.Getenv("ARDUINO_APP_CLI__LOG_LEVEL"), "INFO"))
34+
logLevel, err := ParseLogLevel(cmp.Or(os.Getenv("ARDUINO_APP_CLI__LOG_LEVEL"), "INFO"))
35+
if err != nil {
36+
return err
37+
}
3538
slog.SetLogLoggerLevel(logLevel)
3639

3740
rootCmd := &cobra.Command{
@@ -65,15 +68,23 @@ func main() {
6568
ctx := context.Background()
6669
ctx, _ = cleanup.InterruptableContext(ctx)
6770
if err := rootCmd.ExecuteContext(ctx); err != nil {
68-
slog.Error(err.Error())
71+
return err
72+
}
73+
74+
return nil
75+
}
76+
77+
func main() {
78+
if err := run(); err != nil {
79+
feedback.FatalError(err, 1)
6980
}
7081
}
7182

72-
func ParseLogLevel(level string) slog.Level {
83+
func ParseLogLevel(level string) (slog.Level, error) {
7384
var l slog.Level
7485
err := l.UnmarshalText([]byte(level))
7586
if err != nil {
76-
feedback.Fatal(fmt.Sprintf("Invalid log level: %s\n", level), feedback.ErrGeneric)
87+
return 0, fmt.Errorf("invalid log level: %w", err)
7788
}
78-
return l
89+
return l, nil
7990
}

0 commit comments

Comments
 (0)