ethernet: remove setter overloads

Author: pennam

libraries/Ethernet/src/Ethernet.cpp

@@ -75,12 +75,6 @@ void EthernetClass::end() {
 	disconnect();
 }
 
-void EthernetClass::setMACAddress(const uint8_t *mac_address) {
-	if (mac_address != nullptr) {
-		NetworkInterface::setMACAddress(mac_address);
-	}
-}
-
 IPAddress EthernetClass::localIP() {
 	return NetworkInterface::localIP();
 }
@@ -97,21 +91,5 @@ IPAddress EthernetClass::dnsServerIP() {
 	return NetworkInterface::dnsServerIP();
 }
 
-void EthernetClass::setLocalIP(const IPAddress local_ip) {
-	NetworkInterface::setLocalIP(local_ip);
-}
-
-void EthernetClass::setSubnetMask(const IPAddress subnet) {
-	NetworkInterface::setSubnetMask(subnet);
-}
-
-void EthernetClass::setGatewayIP(const IPAddress gateway) {
-	NetworkInterface::setGatewayIP(gateway);
-}
-
-void EthernetClass::setDnsServerIP(const IPAddress dns_server) {
-	NetworkInterface::setDnsServerIP(dns_server);
-}
-
 EthernetClass Ethernet;
 #endif

libraries/Ethernet/src/Ethernet.h

@@ -62,12 +62,6 @@ class EthernetClass : public NetworkInterface {
 	IPAddress gatewayIP();
 	IPAddress dnsServerIP();
 
-	void setMACAddress(const uint8_t *mac_address);
-	void setLocalIP(const IPAddress local_ip);
-	void setSubnetMask(const IPAddress subnet);
-	void setGatewayIP(const IPAddress gateway);
-	void setDnsServerIP(const IPAddress dns_server);
-
 	void setRetransmissionTimeout(uint16_t milliseconds);
 	void setRetransmissionCount(uint8_t num);
 };

libraries/SocketWrapper/SocketHelpers.cpp

@@ -163,51 +163,40 @@ bool NetworkInterface::setLocalIPFull(IPAddress ip, IPAddress subnet, IPAddress
 		return false;
 	}
 
-	if (!net_if_ipv4_set_netmask_by_addr(netif, &ip_addr, &subnet_addr)) {
-		LOG_ERR("Failed to set subnet mask");
-		return false;
-	}
-
+	net_if_ipv4_set_netmask(netif, &subnet_addr);
 	net_if_ipv4_set_gw(netif, &gw_addr);
 	LOG_INF("Static IP configured");
 	return true;
 }
 
-bool NetworkInterface::setLocalIP(IPAddress ip) {
+void NetworkInterface::setLocalIP(const IPAddress ip) {
 	struct in_addr addr;
 	addr.s_addr = ip;
 
 	if (!net_if_ipv4_addr_add(netif, &addr, NET_ADDR_MANUAL, 0)) {
 		LOG_ERR("Failed to set local IP address");
-		return false;
+		return;
 	}
-
 	LOG_INF("Local IP address set: %s", ip.toString().c_str());
-	return true;
+	return;
 }
 
-bool NetworkInterface::setSubnetMask(IPAddress subnet) {
+void NetworkInterface::setSubnetMask(const IPAddress subnet) {
 	struct in_addr netmask_addr;
 	netmask_addr.s_addr = subnet;
-
-	if (!net_if_ipv4_set_netmask_by_addr(netif, &netmask_addr, &netmask_addr)) {
-		LOG_ERR("Failed to set subnet mask");
-		return false;
-	}
-
+	net_if_ipv4_set_netmask(netif, &netmask_addr);
 	LOG_INF("Subnet mask set: %s", subnet.toString().c_str());
-	return true;
+	return;
 }
 
-bool NetworkInterface::setGatewayIP(IPAddress gateway) {
+void NetworkInterface::setGatewayIP(const IPAddress gateway) {
 	struct in_addr gw_addr;
 	gw_addr.s_addr = gateway;
-
 	net_if_ipv4_set_gw(netif, &gw_addr);
 	LOG_INF("Gateway IP set: %s", gateway.toString().c_str());
-	return true;
+	return;
 }
 
-bool NetworkInterface::setDnsServerIP(IPAddress dns_server) {
-	return false; // DNS server dynamic configuration is not supported
+void NetworkInterface::setDnsServerIP(const IPAddress dns_server) {
+	return; // DNS server dynamic configuration is not supported
 }

libraries/SocketWrapper/SocketHelpers.h

@@ -51,10 +51,10 @@ class NetworkInterface {
 
 	void setMACAddress(const uint8_t *mac);
 	bool setLocalIPFull(IPAddress ip, IPAddress subnet, IPAddress gateway);
-	bool setLocalIP(IPAddress ip);
-	bool setSubnetMask(IPAddress subnet);
-	bool setGatewayIP(IPAddress gateway);
-	bool setDnsServerIP(IPAddress dns_server);
+	void setLocalIP(const IPAddress ip);
+	void setSubnetMask(const IPAddress subnet);
+	void setGatewayIP(const IPAddress gateway);
+	void setDnsServerIP(const IPAddress dns_server);
 
 	int begin(bool blocking = true, uint32_t additional_event_mask = 0);
 

loader/llext_exports.c

@@ -78,7 +78,7 @@ FORCE_EXPORT_SYM(net_if_ipv4_maddr_add);
 FORCE_EXPORT_SYM(net_if_ipv4_maddr_join);
 FORCE_EXPORT_SYM(net_if_ipv4_set_gw);
 FORCE_EXPORT_SYM(net_if_ipv4_addr_add);
-FORCE_EXPORT_SYM(net_if_ipv4_set_netmask_by_addr);
+FORCE_EXPORT_SYM(net_if_ipv4_set_netmask);
 #endif
 FORCE_EXPORT_SYM(net_if_lookup_by_dev);
 #endif