ethernet: squash remove setters

Author: pennam

libraries/SocketWrapper/SocketHelpers.cpp

@@ -169,7 +169,7 @@ bool NetworkInterface::setLocalIPFull(IPAddress ip, IPAddress subnet, IPAddress
 	return true;
 }
 
-void NetworkInterface::setLocalIP(IPAddress ip) {
+void NetworkInterface::setLocalIP(const IPAddress ip) {
 	struct in_addr addr;
 	addr.s_addr = ip;
 
@@ -178,22 +178,25 @@ void NetworkInterface::setLocalIP(IPAddress ip) {
 		return;
 	}
 	LOG_INF("Local IP address set: %s", ip.toString().c_str());
+	return;
 }
 
-void NetworkInterface::setSubnetMask(IPAddress subnet) {
+void NetworkInterface::setSubnetMask(const IPAddress subnet) {
 	struct in_addr netmask_addr;
 	netmask_addr.s_addr = subnet;
 	net_if_ipv4_set_netmask(netif, &netmask_addr);
 	LOG_INF("Subnet mask set: %s", subnet.toString().c_str());
+	return;
 }
 
-void NetworkInterface::setGatewayIP(IPAddress gateway) {
+void NetworkInterface::setGatewayIP(const IPAddress gateway) {
 	struct in_addr gw_addr;
 	gw_addr.s_addr = gateway;
 	net_if_ipv4_set_gw(netif, &gw_addr);
 	LOG_INF("Gateway IP set: %s", gateway.toString().c_str());
+	return;
 }
 
-void NetworkInterface::setDnsServerIP(IPAddress dns_server) {
+void NetworkInterface::setDnsServerIP(const IPAddress dns_server) {
 	return; // DNS server dynamic configuration is not supported
 }

libraries/SocketWrapper/SocketHelpers.h

@@ -51,10 +51,10 @@ class NetworkInterface {
 
 	void setMACAddress(const uint8_t *mac);
 	bool setLocalIPFull(IPAddress ip, IPAddress subnet, IPAddress gateway);
-	void setLocalIP(IPAddress ip);
-	void setSubnetMask(IPAddress subnet);
-	void setGatewayIP(IPAddress gateway);
-	void setDnsServerIP(IPAddress dns_server);
+	void setLocalIP(const IPAddress ip);
+	void setSubnetMask(const IPAddress subnet);
+	void setGatewayIP(const IPAddress gateway);
+	void setDnsServerIP(const IPAddress dns_server);
 
 	int begin(bool blocking = true, uint32_t additional_event_mask = 0);