cores/arduino: warning squash

Silence a number of trivial compiler warnings in the Arduino core:
- unused arguments
- "constexpr const"
- signed/unsigned mismatches

Signed-off-by: Luca Burelli <l.burelli@arduino.cc>

Author: pillo79

cores/arduino/USB.cpp

@@ -14,6 +14,7 @@
 const struct device *const usb_dev = DEVICE_DT_GET(DT_PHANDLE_BY_IDX(DT_PATH(zephyr_user), cdc_acm, 0));
 
 void usb_status_cb(enum usb_dc_status_code cb_status, const uint8_t *param) {
+    (void)param; // unused
     if (cb_status == USB_DC_CONFIGURED) {
 
     }
@@ -34,6 +35,7 @@ void arduino::SerialUSB_::_baudChangeHandler()
 
 static void _baudChangeHandler(const struct device *dev, uint32_t rate)
 {
+    (void)dev; // unused
     if (rate == 1200) {
         usb_disable();
         _on_1200_bps();
@@ -123,4 +125,4 @@ arduino::SerialUSB_::operator bool() {
 }
 
 arduino::SerialUSB_ Serial(usb_dev);
-#endif
+#endif

cores/arduino/abi.cpp

@@ -9,6 +9,7 @@
 extern "C" void __cxa_pure_virtual(void) {}
 extern "C" void __cxa_deleted_virtual(void) {}
 extern "C" int __cxa_atexit(void (*func) (void *), void * arg, void * dso_handle) {
+  (void)func; (void)arg; (void)dso_handle; // unused
   return 0;
 }
 

cores/arduino/main.cpp

@@ -70,6 +70,8 @@ static void __libc_init_array (void)
 }
 
 extern "C" __attribute__((section(".entry_point"), used)) void entry_point(struct k_heap* stack, size_t stack_size) {
+  (void)stack; (void)stack_size; // unused
+
   // copy .data in the right place
   // .bss should already be in the right place
   // call constructors
@@ -85,14 +87,12 @@ extern "C" __attribute__((section(".entry_point"), used)) void entry_point(struc
 
   //__asm volatile ("cpsie i");
 
-  const size_t alignment = 4096;
   printk("System Heap end: %p\n", &__heap_end);
   printk("System Heap start: %p\n", &__heap_start);
   printk("Sketch Heap start: %p, size %p\n", &kheap_llext_heap, &kheap_llext_heap_size);
-  // __heap_start = (__heap_start + (alignment - 1)) & ~(alignment - 1);
 
   memcpy(&_sdata, &_sidata, (&_edata - &_sdata) * sizeof(uint32_t));
   memset(&_sbss, 0, &_ebss - &_sbss);
   __libc_init_array();
   main();
-}
+}

cores/arduino/new.cpp

@@ -46,14 +46,17 @@ void * operator new[](std::size_t size) {
 
 #if __cplusplus >= 201703L
 void* operator new(std::size_t count, std::align_val_t al) {
+  (void)al; // unused
   return operator new(count);
 }
 
 void* operator new[](std::size_t count, std::align_val_t al) {
+  (void)al; // unused
   return operator new(count);
 }
 
 void * operator new(std::size_t size, std::align_val_t al, const std::nothrow_t tag) noexcept {
+  (void)al; (void)tag; // unused
 #if defined(NEW_TERMINATES_ON_FAILURE)
   // Cannot call throwing operator new as standard suggests, so call
   // new_helper directly then
@@ -64,6 +67,7 @@ void * operator new(std::size_t size, std::align_val_t al, const std::nothrow_t
 }
 
 void * operator new[](std::size_t size, std::align_val_t al, const std::nothrow_t& tag) noexcept {
+  (void)al; (void)tag; // unused
 #if defined(NEW_TERMINATES_ON_FAILURE)
   // Cannot call throwing operator new[] as standard suggests, so call
   // malloc directly then
@@ -75,6 +79,7 @@ void * operator new[](std::size_t size, std::align_val_t al, const std::nothrow_
 #endif
 
 void * operator new(std::size_t size, const std::nothrow_t tag) noexcept {
+  (void)tag; // unused
 #if defined(NEW_TERMINATES_ON_FAILURE)
   // Cannot call throwing operator new as standard suggests, so call
   // new_helper directly then
@@ -84,6 +89,7 @@ void * operator new(std::size_t size, const std::nothrow_t tag) noexcept {
 #endif
 }
 void * operator new[](std::size_t size, const std::nothrow_t& tag) noexcept {
+  (void)tag; // unused
 #if defined(NEW_TERMINATES_ON_FAILURE)
   // Cannot call throwing operator new[] as standard suggests, so call
   // malloc directly then
@@ -111,17 +117,21 @@ void operator delete[](void * ptr) noexcept {
 
 #if __cplusplus >= 201402L
 void operator delete(void* ptr, std::size_t size) noexcept {
+  (void)size; // unused
   operator delete(ptr);
 }
 void operator delete[](void * ptr, std::size_t size) noexcept {
+  (void)size; // unused
   operator delete[](ptr);
 }
 #endif // __cplusplus >= 201402L
 
 void operator delete(void* ptr, const std::nothrow_t& tag) noexcept {
+  (void)tag; // unused
   operator delete(ptr);
 }
 void operator delete[](void* ptr, const std::nothrow_t& tag) noexcept {
+  (void)tag; // unused
   operator delete[](ptr);
 }
 

cores/arduino/zephyrCommon.cpp

@@ -18,37 +18,37 @@ namespace {
  * Calculate GPIO ports/pins number statically from devicetree configuration
  */
 
-template <class N, class Head> constexpr const N sum_of_list(const N sum, const Head &head)
+template <class N, class Head> constexpr N sum_of_list(const N sum, const Head &head)
 {
   return sum + head;
 }
 
 template <class N, class Head, class... Tail>
-constexpr const N sum_of_list(const N sum, const Head &head, const Tail &...tail)
+constexpr N sum_of_list(const N sum, const Head &head, const Tail &...tail)
 {
   return sum_of_list(sum + head, tail...);
 }
 
-template <class N, class Head> constexpr const N max_in_list(const N max, const Head &head)
+template <class N, class Head> constexpr N max_in_list(const N max, const Head &head)
 {
   return (max >= head) ? max : head;
 }
 
 template <class N, class Head, class... Tail>
-constexpr const N max_in_list(const N max, const Head &head, const Tail &...tail)
+constexpr N max_in_list(const N max, const Head &head, const Tail &...tail)
 {
   return max_in_list((max >= head) ? max : head, tail...);
 }
 
 template <class Query, class Head>
-constexpr const size_t is_first_appearance(const size_t &idx, const size_t &at, const size_t &found,
+constexpr size_t is_first_appearance(const size_t &idx, const size_t &at, const size_t &found,
              const Query &query, const Head &head)
 {
   return ((found == ((size_t)-1)) && (query == head) && (idx == at)) ? 1 : 0;
 }
 
 template <class Query, class Head, class... Tail>
-constexpr const size_t is_first_appearance(const size_t &idx, const size_t &at, const size_t &found,
+constexpr size_t is_first_appearance(const size_t &idx, const size_t &at, const size_t &found,
              const Query &query, const Head &head,
              const Tail &...tail)
 {
@@ -119,6 +119,7 @@ void setInterruptHandler(pin_size_t pinNumber, voidFuncPtr func)
 
 void handleGpioCallback(const struct device *port, struct gpio_callback *cb, uint32_t pins)
 {
+  (void)port; // unused
   struct gpio_port_callback *pcb = (struct gpio_port_callback *)cb;
 
   for (uint32_t i = 0; i < max_ngpios; i++) {

cores/arduino/zephyrSerial.cpp

@@ -116,6 +116,7 @@ void arduino::ZephyrSerial::IrqHandler()
 
 void arduino::ZephyrSerial::IrqDispatch(const struct device *dev, void *data)
 {
+	(void)dev; // unused
 	reinterpret_cast<ZephyrSerial *>(data)->IrqHandler();
 }
 
@@ -165,7 +166,7 @@ int arduino::ZephyrSerial::read()
 
 size_t arduino::ZephyrSerial::write(const uint8_t *buffer, size_t size)
 {
-	int idx = 0;
+	size_t idx = 0;
 
 	while (1) {
 		k_sem_take(&tx.sem, K_FOREVER);