Make ring buffer head and tail indexes volatile #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
facchinm
approved these changes
Feb 14, 2018
boseji
pushed a commit
to go-ut/combined-ArduinoCore-samd
that referenced
this pull request
Nov 10, 2021
* more Adafruit_TinyUSB include * add metro m0 m4 with tinyusb to ci * correct fqbn * support ci with tinyusb variant bump zeroDMA and fix warnings with USBHost library example * install missing libraries * more libraries * update tinyusb library to 1.2.0 increase version to 1.7.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having some issues running some MKRGSM lib examples with the latest SAMD core master. 503a9b3 introduced an issue, however making the ring buffer head and tail indexes volatile allows things to work again. They probably should have been volatile in the original non-templated version.