Skip to content

Fixed min/max definition and other macros as well #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2015
Merged

Fixed min/max definition and other macros as well #12

merged 1 commit into from
Jun 25, 2015

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented Jun 22, 2015

It seems that

#include <stdint.h>

is able to undef "min" and "max" previously defined. With this commit we make sure that they are defined as last.

Fix #10

@cmaglie cmaglie self-assigned this Jun 22, 2015
@cmaglie cmaglie mentioned this pull request Jun 22, 2015
Closed
@cmaglie
Fixed min/max definition and other macros as well
a546da2 
It seems that

   #include <stdint.h>

is able to undef "min" and "max" previously defined. With this
commit we make sure that they are defined as last.

Fix arduino#10
@ArduinoBot
Copy link

ArduinoBot commented Jun 25, 2015

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/samd/package_samd-b1_index.json

ℹ️ To test this build:

  1. Open the Preferences of the Arduino IDE.
  2. Add the Build URL above in the Additional Boards Manager URLs field, and click OK.
  3. Open the Boards Manager (menu Tools->Board->Board Manager...)
  4. Install Arduino SAMD core - Pull Request Fixed min/max definition and other macros as well #12
  5. Select one of the boards under SAMD Pull Request Fixed min/max definition and other macros as well #12 in Tools->Board menu
  6. Compile/Upload as usual

@ArduinoBot
Copy link

ArduinoBot commented Jun 25, 2015

Test PASSed.

@cmaglie cmaglie merged commit a546da2 into arduino:master Jun 25, 2015
@cmaglie cmaglie deleted the min-max-fix branch June 25, 2015 13:49
@cmaglie cmaglie added this to the Release 1.6.1 milestone Jul 18, 2015
@cmaglie cmaglie added the bug label Jul 18, 2015
facchinm pushed a commit that referenced this pull request Jan 16, 2019
@mattairtech
Merge pull request #12 from joseangeljimenez/patch-2
d41f87d 
Correction of include path for CMSIS-Atmel - Thanks @joseangeljimenez
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cmaglie cmaglie

Labels

bug

Projects

None yet

Milestone

Release 1.6.1

Development

Successfully merging this pull request may close these issues.

2 participants

@cmaglie @ArduinoBot