Make assigning PULLEN value in digitalWrite a bit clearer

sandeepmistry · sandeepmistry · commit a08cb3fea929 · 2016-01-21T14:27:04.000-05:00
diff --git a/cores/arduino/wiring_digital.c b/cores/arduino/wiring_digital.c
@@ -88,7 +88,7 @@ void digitalWrite( uint32_t ulPin, uint32_t ulVal )
 
   if ( (PORT->Group[port].DIRSET.reg & pinMask) == 0 ) {
     // the pin is not an output, disable pull-up if val is LOW, otherwise enable pull-up
-    PORT->Group[port].PINCFG[pin].bit.PULLEN = (ulVal != LOW) ;
+    PORT->Group[port].PINCFG[pin].bit.PULLEN = ((ulVal == LOW) ? 0 : 1) ;
   }
 
   switch ( ulVal )

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ void digitalWrite( uint32_t ulPin, uint32_t ulVal )`
`88`	`88`
`89`	`89`	`if ( (PORT->Group[port].DIRSET.reg & pinMask) == 0 ) {`
`90`	`90`	`// the pin is not an output, disable pull-up if val is LOW, otherwise enable pull-up`
`91`		`- PORT->Group[port].PINCFG[pin].bit.PULLEN = (ulVal != LOW) ;`
	`91`	`+ PORT->Group[port].PINCFG[pin].bit.PULLEN = ((ulVal == LOW) ? 0 : 1) ;`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`switch ( ulVal )`