dealing with retrocompatibility

Author: andreagilardoni

libraries/lwIpWrapper/src/CNetIf.cpp

@@ -428,7 +428,7 @@ CEth::CEth(NetworkDriver *driver)
     // driver.stats = &this->stats;
 }
 
-int CEth::begin(const IPAddress &ip, const IPAddress &nm, const IPAddress &gw) {
+int CEth::begin(const IPAddress &ip, const IPAddress &nm, const IPAddress &gw, const IPAddress &dns) {
     // The driver needs a callback to consume the incoming buffer
     this->driver->setConsumeCallback(
         std::bind(&CEth::consume_callback,
@@ -438,10 +438,11 @@ int CEth::begin(const IPAddress &ip, const IPAddress &nm, const IPAddress &gw) {
     CNetIf::begin(ip, nm, gw);
     netif_set_link_up(&this->ni); // TODO test that moving this here still makes ethernet work
 
+    // TODO set dns server
+
     return 0;
 }
 
-
 err_t CEth::init(struct netif* ni) {
     // Setting up netif
 #if LWIP_NETIF_HOSTNAME

libraries/lwIpWrapper/src/CNetIf.h

@@ -202,12 +202,22 @@ class CEth : public CNetIf {
     virtual int begin(
         const IPAddress &ip = INADDR_NONE,
         const IPAddress &nm = INADDR_NONE,
-        const IPAddress &gw = INADDR_NONE) override;
+        const IPAddress &gw = INADDR_NONE,
+        const IPAddress &dns = INADDR_NONE);
+
+    // virtual int begin(
+    //     const IPAddress &ip = INADDR_NONE,
+    //     const IPAddress &nm = INADDR_NONE,
+    //     const IPAddress &gw = INADDR_NONE,
+    //     const IPAddress &dns = INADDR_NONE);
 
     virtual int getMacAddress(uint8_t* mac) override {
         UNUSED(mac); // FIXME not implemented
         return 1;
     }
+
+    int maintain() {} // Deprecated method for retrocompatibility
+    void schedule(void) {} // Deprecated method for retrocompatibility
 protected:
     /*
      * this function is used to initialize the netif structure of lwip