Merge branch 'main' of github.com:arduino/ArduinoCore-mbed

Author: facchinm

libraries/Ethernet/src/Ethernet.cpp

@@ -8,7 +8,11 @@ int arduino::EthernetClass::begin(uint8_t *mac, unsigned long timeout, unsigned
     _initializerCallback();
     if (eth_if == nullptr) return 0;
   }
+  eth_if->set_dhcp(true);
+  _begin(mac, timeout, responseTimeout);
+}
 
+int arduino::EthernetClass::_begin(uint8_t *mac, unsigned long timeout, unsigned long responseTimeout) {
   if (mac != nullptr) {
     eth_if->get_emac().set_hwaddr(mac);
   }
@@ -53,7 +57,7 @@ int arduino::EthernetClass::begin(uint8_t *mac, IPAddress ip, IPAddress dns, IPA
   eth_if->set_network(_ip, _netmask, _gateway);
   eth_if->add_dns_server(_dnsServer1, nullptr);
 
-  auto ret = begin(mac, timeout, responseTimeout);
+  auto ret = _begin(mac, timeout, responseTimeout);
   return ret;
 }
 

libraries/Ethernet/src/Ethernet.h

@@ -116,6 +116,8 @@ class EthernetClass : public MbedSocketClass {
   constexpr static int maintain () { return DHCP_CHECK_NONE; }
 
 private:
+  int _begin(uint8_t *mac, unsigned long timeout, unsigned long responseTimeout);
+
   volatile EthernetLinkStatus _currentNetworkStatus = Unknown;
   EthernetInterface net;
   EthernetInterface *eth_if = &net;

libraries/GSM/src/GSMDebug.cpp

@@ -188,14 +188,16 @@ const char * arduino::GSMClass::getRegistrationStateString(const mbed::CellularN
 
 void arduino::GSMClass::onStatusChange(nsapi_event_t ev, intptr_t in) {
 
-  if(ev == CellularStateRetryEvent) {
+  cellular_event_status event = (cellular_event_status)ev;
+
+  if(event == CellularStateRetryEvent) {
     feedWatchdog();
   }
 
 #if GSM_DEBUG_ENABLE
   const cell_callback_data_t *data = (const cell_callback_data_t *)in;
 
-  switch(ev)
+  switch(event)
   {
     case CellularDeviceReady:
     {

libraries/SFU/src/SFU.cpp

@@ -21,14 +21,17 @@ int SFU::begin() {
     if (err) {
         err = getFileSystem().reformat(&bd);
     }
+    return err;
 }
 
 int SFU::download(const char* url) {
-	// No download at the moment, allow the user to upload a file via mass storage
+    // No download at the moment, allow the user to upload a file via mass storage
+    return 0;
 }
 
 int SFU::apply() {
-	// No autoreboot
+    // No autoreboot
+    return 0;
 }
 
 #ifdef ADD_USB_MSD

libraries/WiFi/src/WiFi.cpp

@@ -69,6 +69,10 @@ int arduino::WiFiClass::beginAP(const char* ssid, const char* passphrase, uint8_
   //Set ap ssid, password and channel
   softAPInterface->set_network(_ip, _netmask, _gateway);
   nsapi_error_t result = softAPInterface->start(ssid, passphrase, NSAPI_SECURITY_WPA2, channel, true /* dhcp server */, NULL, true /* cohexistance */);
+  if (result != NSAPI_ERROR_OK) {
+    _currentNetworkStatus = WL_AP_FAILED;
+    return _currentNetworkStatus;
+  }
 
   nsapi_error_t registrationResult;
   softAPInterface->unregister_event_handler();