Skip to content

SerialFlash: enlarge chip ID buffer #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

SerialFlash: enlarge chip ID buffer #207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libraries/SerialFlash/SerialFlashDirectory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,9 @@ bool SerialFlashChip::create(const char *filename, uint32_t length, uint32_t ali
// last check, if enough space exists...
len = strlen(filename);
// TODO: check for enough string space for filename
uint8_t id[3];

// 5 bytes, to allow for extra 2 bytes in Spansion device IDs
uint8_t id[5];
SerialFlash.readID(id);
if (address + length > SerialFlash.capacity(id)) return false;

Expand Down