Skip to content

Subtract one from USB_EP_SIZE in USB_SendSpace #4864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2016
Merged

Subtract one from USB_EP_SIZE in USB_SendSpace #4864

merged 1 commit into from
Jul 11, 2016

Conversation

@sandeepmistry
Copy link
Contributor

@sandeepmistry sandeepmistry commented Apr 14, 2016

This avoids dealing with ZLP’s in USB_Send, because the max packet size will be EP size - 1.

Alternative to #4138 to resolve #3946.

cc/ @NicoHood @embmicro @BlackBrix.

@sandeepmistry
Subtract one from USB_EP_SIZE in USB_SendSpace
817d700 
This avoids dealing with ZLP’s in USB_Send, because the max packet size
will be EP size - 1.
@sandeepmistry sandeepmistry mentioned this pull request Apr 14, 2016
Closed
@sandeepmistry sandeepmistry added feature request A request to make an enhancement (not a bug fix) USB: CDC serial Serial interface used by MCUs with native USB (e.g. Leonardo) to communicate with the computer Architecture: AVR Applies only to the AVR microcontrollers (Uno, etc.) labels Apr 14, 2016
@ArduinoBot
Copy link
Contributor

ArduinoBot commented Apr 14, 2016

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4864-BUILD-552-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4864-BUILD-552-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4864-BUILD-552-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4864-BUILD-552-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4864-BUILD-552-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

@sandeepmistry sandeepmistry mentioned this pull request Jun 6, 2016
Closed
@agdl agdl merged commit bbd3ae2 into arduino:master Jul 11, 2016
@NicoHood
Copy link
Contributor

NicoHood commented Jul 11, 2016

Was this internally discussed and tested?

@agdl
Copy link
Member

agdl commented Jul 12, 2016

@NicoHood Yes, tested by me on Ubuntu and Windows. If you can also try it out is good :)

@sandeepmistry sandeepmistry deleted the avr-usb-tx branch July 18, 2016 17:58
@sandeepmistry sandeepmistry added this to the Release 1.6.10 milestone Jul 19, 2016
@jh1-git jh1-git mentioned this pull request Nov 6, 2016
Closed
@NicoHood
Copy link
Contributor

NicoHood commented Nov 6, 2016 •
edited
Loading

A user reported that this PR breaks the raw hid code:
NicoHood/HID#91

The ZLP needs to be handled inside the Serial, not the USB-Core. Please revert this commit and think of another solution. This possibly also breaks other USB libs.

@sandeepmistry
Copy link
Contributor Author

sandeepmistry commented Nov 7, 2016

@NicoHood thanks for letting us know.

Do you have any suggestions on how to move forward? Please note, the SAMD core has the same behaviour as this PR: arduino/ArduinoCore-samd@40d9554.

@NicoHood
Copy link
Contributor

NicoHood commented Nov 8, 2016

No I dont know how to solve this problem, but I remember that there were multiple solutions provided. I'd revert the PR for now, as this is defenitely implemented wrong and needs to move to the serial library, not the usb core.

@NicoHood NicoHood mentioned this pull request Dec 16, 2016
Closed
@facchinm facchinm mentioned this pull request Jan 4, 2017
Merged
cmaglie added a commit to facchinm/Arduino that referenced this pull request Jan 4, 2017
@cmaglie
[AVR] USB send ZLP when needed
a540126 
See arduino#5732 arduino#4864 arduino#4138 arduino#3946
cmaglie added a commit that referenced this pull request Mar 16, 2017
@cmaglie
[AVR] USB send ZLP when needed
3c0f26d 
See #5732 #4864 #4138 #3946
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Architecture: AVR Applies only to the AVR microcontrollers (Uno, etc.) feature request A request to make an enhancement (not a bug fix) USB: CDC serial Serial interface used by MCUs with native USB (e.g. Leonardo) to communicate with the computer

Projects

None yet

Milestone

Release 1.6.10

Development

Successfully merging this pull request may close these issues.

Leonardo fails to send exactly 64 bytes.

4 participants

@sandeepmistry @ArduinoBot @NicoHood @agdl