Fix adding NULL value to the preferences when iserial is not defined #4472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 16, 2015 13:09
Contributor
|
I can confirm that the change proposed by @me-no-dev works for me and would close #4471. |
Collaborator
|
This fix looks good to me, just tested it with a Pinocc.io board (which had the same problem). @me-no-dev could you rebase your branch on top of the latest master to remove the merge commits? If you then force push to the branch used to create this PR, the PR should be updated to only contain the relevant commit, without needlessly making the commit history more complex. |
Member
|
Rebased and merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connected to: #4471